PostBuildChecks: Append output to stdout-<triplet>.log #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Feb 27, 2023
Neumann-A
reviewed
Feb 27, 2023
BillyONeal
requested changes
Feb 27, 2023
include/vcpkg/base/messages.h
Outdated
| @@ -412,6 +412,32 @@ namespace vcpkg | |||
| this->print(c, msg::format(m, args...).append_raw('\n')); | |||
| } | |||
|
|
|||
| void println_warning(const LocalizedString& s); | |||
There was a problem hiding this comment.
I'm weakly against this: output redirection and formatting the error prefix on are separate concerns and I don't think sink.println(msg::format_error(msgFoo)) is that onerous. But I am on record as not being a fan of any "format wrappers" so we should get other maintainers' thoughts.
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com> Co-authored-by: Billy O'Neal <bion@microsoft.com>
|
I have now moved the |
BillyONeal
reviewed
Mar 2, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Mar 9, 2023
|
Thanks! |
autoantwort
deleted the
feature/log-postbuildchecks-to-stdout-<triplet>.log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/vcpkg#11219