Skip to content

Commit

Permalink
[openblas] Fix build errors on osx (#36072)
Browse files Browse the repository at this point in the history
Fixes #36031

```
ld: error: undefined symbol: cabsf
>>> referenced by c_cblat2c.c:3566 (/home/CORP/b.manganelli/Projects/vcpkg/buildtrees/openblas/src/v0.3.25-dc6d649124.clean/ctest/c_cblat2c.c:3566)
>>>               ctest/CMakeFiles/xccblat2.dir/c_cblat2c.c.o:(cmvch_)
```

- [X] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md)
- [ ] ~~SHA512s are updated for each updated download~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [X] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

```
x64-windows
x64-osx
```

---------

Co-authored-by: Jim wang (BEYONDSOFT CONSULTING INC) <v-wangjim@microsoft.com>
  • Loading branch information
jimwang118 and jimwang118 committed Feb 27, 2024
1 parent aa7f97c commit 3dd44b9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 1 deletion.
5 changes: 5 additions & 0 deletions ports/openblas/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,16 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
set(COMMON_OPTIONS -DBUILD_WITHOUT_LAPACK=ON)

if(VCPKG_TARGET_IS_OSX)
list(APPEND COMMON_OPTIONS -DONLY_CBLAS=1)
if("dynamic-arch" IN_LIST FEATURES)
set(conf_opts GENERATOR "Unix Makefiles")
endif()
endif()

if(VCPKG_TARGET_IS_ANDROID)
list(APPEND COMMON_OPTIONS -DONLY_CBLAS=1)
endif()

set(OPENBLAS_EXTRA_OPTIONS)
# for UWP version, must build non uwp first for helper
# binaries.
Expand Down
1 change: 1 addition & 0 deletions ports/openblas/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "openblas",
"version": "0.3.26",
"port-version": 1,
"description": "OpenBLAS is an optimized BLAS library based on GotoBLAS2 1.13 BSD version.",
"homepage": "https://github.com/xianyi/OpenBLAS",
"license": "BSD-3-Clause",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -6310,7 +6310,7 @@
},
"openblas": {
"baseline": "0.3.26",
"port-version": 0
"port-version": 1
},
"opencascade": {
"baseline": "7.8.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/o-/openblas.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "162536c889250c48f1c0aaa8c7cae66806f467b3",
"version": "0.3.26",
"port-version": 1
},
{
"git-tree": "3fde0f066aa319941b8f352596f28a92f099b2f5",
"version": "0.3.26",
Expand Down

0 comments on commit 3dd44b9

Please sign in to comment.