Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] upgrade --no-dry-run - Should the change in the new Port-Version field in the port's CONTROL file cause removal/rebuild of port and its features? #12234

Closed
ghost opened this issue Jul 2, 2020 · 5 comments · Fixed by #12227
Closed

[vcpkg] upgrade --no-dry-run - Should the change in the new Port-Version field in the port's CONTROL file cause removal/rebuild of port and its features? #12234

ghost opened this issue Jul 2, 2020 · 5 comments · Fixed by #12227
Assignees
@strega-nil @PhoebeHui
Labels
category:question This issue is a question category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:manifests This PR or Issue pertains to the Manifests feature

Comments

@ghost
Copy link

ghost commented Jul 2, 2020 •
edited by ghost
Loading

.\vcpkg upgrade --no-dry-run

  • Should the change in the new Port-Version field in the port's CONTROL file cause removal/rebuild of port and its features?

  • Referenced: https://vcpkg.readthedocs.io/en/latest/maintainers/control-files/ paragraph Version does not mention specifically the new Port-Version field.

  • I noticed in commit ef91134 the ports' CONTROL files have a Version and Port-Version having had the Port-Version incremented up by 1.

  • I have several of these ports installed, libpq, libiconv, libarchive and the CONTROL and vcpkg-cmake-wrapper.cmake files were updated on my instances, 4 on windows, 2 on OpenSUSE Linux (One VM one WSL2) with a git pull but when doing a vcpkg upgrade on all the instances none of them were flagged as needing to be upgraded

  • The response I received after a vcpkg upgrade --no-dry-run was All installed packages are up-to-date with local portfiles.

  • I would think splitting the Port-Version from the Version, a change in either would cause the port to be flagged for removal/reinstallation by vcpkg upgrade as the Port-Version would seem to be now for changes made like adding features, fixes, documentation, etc to a current version, but signaling the port needs to be rebuilt?

  • I also noticed the Port-Version no longer shows on the port when a vcpkg list or vcpkg search is performed, just the base version found on Version in the CONTROL file (see attached vcpkg-search.txt and vcpkg-list noting only base version is shown on libpg, libiconv and libarchive).

  • See attached files for vcpkg list vcpkg search and ls -al of <vcpkg-root>\ports\libarchive showing CONTROL and vcpkg-cmake-wrapper.cmake files updated.
    ls-al.txt
    vcpkg-search.txt
    vcpkg-list.txt

  • ac-130h@Andromeda:[~/git/vcpkg]
    >$ vcpkg update
    Using local portfile versions. To update the local portfiles, use git pull.
    No packages need updating.

  • Please advise further?

Thank you and have a wonderful holiday weekend :)
@PhoebeHui PhoebeHui added the category:question This issue is a question label Jul 6, 2020
@strega-nil strega-nil added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Jul 6, 2020
@strega-nil
Copy link
Contributor

Fixed by #12227 :)

strega-nil added a commit to strega-nil/vcpkg that referenced this issue Jul 6, 2020
@strega-nil
Fix microsoft#12234
c2d062b
@ghost
Copy link
Author

ghost commented Jul 6, 2020

Thank you @strega-nil.

@ghost ghost closed this as completed Jul 6, 2020
@strega-nil
Copy link
Contributor

This isn't actually fixed quite yet, we still need to merge #12227

@strega-nil strega-nil reopened this Jul 6, 2020
@ghost
Copy link
Author

ghost commented Jul 6, 2020

This isn't actually fixed quite yet, we still need to merge #12227

Ooopps - I acted too quickly, I apologize.

@strega-nil strega-nil mentioned this issue Jul 6, 2020
Merged
@strega-nil strega-nil added the info:manifests This PR or Issue pertains to the Manifests feature label Jul 8, 2020
strega-nil added a commit that referenced this issue Jul 9, 2020
@strega-nil
[vcpkg manifests] fix some issues (#12227)
3871d73 
Fixes #12190
Fixes #12208
Fixes #12234
Fixes #12286
Fixes #12315
Fixes #12186
Fixes #12331
Fixes googleapis/google-cloud-cpp#4487
@ghost
Copy link
Author

ghost commented Jul 9, 2020

Thank you @strega-nil

strega-nil added a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
@strega-nil
[vcpkg manifests] fix some issues (microsoft#12227)
e308846 
Fixes microsoft#12190
Fixes microsoft#12208
Fixes microsoft#12234
Fixes microsoft#12286
Fixes microsoft#12315
Fixes microsoft#12186
Fixes microsoft#12331
Fixes googleapis/google-cloud-cpp#4487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
category:question This issue is a question category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:manifests This PR or Issue pertains to the Manifests feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg manifests] fix some issues strega-nil/vcpkg
2 participants
@strega-nil @PhoebeHui