Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freetype] compiling with brotli support for woff2 and linking #12380

Closed
kevinlul opened this issue Jul 11, 2020 · 1 comment · Fixed by #12405
Closed

[freetype] compiling with brotli support for woff2 and linking #12380

kevinlul opened this issue Jul 11, 2020 · 1 comment · Fixed by #12405
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@kevinlul
Copy link
Contributor

kevinlul commented Jul 11, 2020


Is your feature request related to a problem? Please describe.
With the freetype 2.10.2 update merged in #11846, support for WOFF 2 fonts was added but not accounted for when I updated the port. Thus, depending on whether brotli is already installed, it might be detected, support compiled, and linked in. The vcpkg brotli port does not export the library as BrotliDec like freetype expects, but as unofficial::brotli::brotli-SOMETHING, and I'm not sure why it's configured in this way.

Proposed solution
Add an optional feature brotli to control FT_WITH_BROTLI and CMAKE_DISABLE_FIND_PACKAGE_BrotliDec. Then either freetype must be patched to use the unofficial vcpkg CMake module names for brotli, or the unofficial CMake module names for brotli should be removed in favour of the official ones. I'm not sure why the unofficial names were added in the first place two years ago 33286f9.

Describe alternatives you've considered
Disable brotli support entirely like with HarfBuzz. Doesn't seem like a good idea to throw out an entire feature.

Additional context
I think #9838 might be related with the brotli CMake module names.

@Neumann-A
Copy link
Contributor

Hmm i actually touched this issue in #11776. The problem is that the pkgconfig file for brotli is incorrect which is why it is not found by freetype. freetype itself uses a FindBrotliDec module which internally uses FindPkgConfig for brotli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants