Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg broken build due to unused variable syntax #13094

Closed
linquize opened this issue Aug 23, 2020 · 0 comments · Fixed by #13117
Closed

vcpkg broken build due to unused variable syntax #13094

linquize opened this issue Aug 23, 2020 · 0 comments · Fixed by #13117
Assignees
@BillyONeal @JackBoosY
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@linquize
Copy link

Describe the bug
vcpkg broken build since 5e164e3

../src/vcpkg/commands.xvsinstances.cpp:31:16: error: left operand of comma operator has no effect [-Werror=unused-value]
31 | (void)(args, paths);
| ^~~~
cc1plus: all warnings being treated as errors

Environment

  • OS: Ubuntu 20.04
  • Compiler: gcc 9.3

To Reproduce
Steps to reproduce the behavior:
cmake -B build -G Ninja
cmake --build build

Expected behavior
No error
@linquize linquize changed the title vcpkg broken build since 5e164e3dd2b9fbbd68782f4c3c73242918b3c688 vcpkg broken build due to unused variable syntax Aug 23, 2020
@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Aug 24, 2020
BillyONeal added a commit to BillyONeal/vcpkg that referenced this issue Aug 24, 2020
@BillyONeal
Fix microsoft#13094 by avoiding the comma operator.
eedc358 
Drive-by remove unused parenthesis and remove macro inversion in metrics.cpp.
@BillyONeal BillyONeal mentioned this issue Aug 24, 2020
Merged
BillyONeal added a commit that referenced this issue Aug 25, 2020
@BillyONeal
[vcpkg] Fix #13094 by avoiding the comma operator. (#13117)
64cbded 
* Fix #13094 by avoiding the comma operator.

Drive-by remove unused parenthesis and remove macro inversion in metrics.cpp.
strega-nil pushed a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
@BillyONeal
[vcpkg] Fix microsoft#13094 by avoiding the comma operator. (microsof…
7e5b515 
…t#13117)

* Fix microsoft#13094 by avoiding the comma operator.

Drive-by remove unused parenthesis and remove macro inversion in metrics.cpp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillyONeal BillyONeal

@JackBoosY JackBoosY

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg] Fix #13094 by avoiding the comma operator. BillyONeal/vcpkg
3 participants
@linquize @BillyONeal @JackBoosY