[brotli] build failure

[ghost]

Host Environment

• OS: Windows
• Compiler: MS VC 2019

To Reproduce
Steps to reproduce the behavior:
./vcpkg install sfml

Failure logs
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
Library "brotlicommon" was not found! If it is a system library use the
SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
correct the *.pc file
Call Stack (most recent call first):
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:298 (vcpkg_fixup_pkgconfig_check_files)
ports/brotli/portfile.cmake:25 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:79 (include)

Error: Building package brotli:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: brotli:x86-windows
Vcpkg version: 2020.06.15-nohash

Additional context
I used git pull and vcpkg install brotli and failed 5 times. I wanted to build sfml, but I haven't manage to deal with brotli.

[Neumann-A]

Without any further debug output I would assume it is the same issue as #13105

[sfhacker]

@darkwarrior703 Probably your environment is broken or 'polluted'!

[sfhacker]

We have faced no issues (at all) building brotli!

Pardon my ignorance, but is brotli a dependency somewhere?

[ghost]

I think that brotli is a dependency for sfml. When I try to install sfml, vcpkg tries to install brotli.

[sfhacker]

@darkwarrior703 When I built sfml, it didn't ask for brotli at all! I may be wrong, but ....
Can someone confirm whether or not brotli is a dependency in this case?

[Neumann-A]

$ ./vcpkg.exe depend-info sfml
zlib:
brotli:
bzip2:
libogg:
libpng: zlib
freetype[bzip2, png]: brotli, bzip2, libpng, zlib
libflac: libogg
libvorbis: libogg
openal-soft:
stb:
sfml: freetype, libflac, libogg, libvorbis, openal-soft, stb

sfml -> freetype -> brotli

[sfhacker]

It seems that brotli is an indirect dependency.
@darkwarrior703 Can you build sfml without freetype? Just for testing purposes.

[ghost]

I think there's a problem with CMake because brotlicommon.lib file exists. I checked the directory. How to build a library without a dependency?
Edit: I tried to install other dependency like libogg and the same problem. It isn't a problem with brotli. It's CMake's fault.

[Neumann-A]

I feel like I am being ignored:

Without any further debug output I would assume it is the same issue as #13105

[Neumann-A]

You can tryout PR #13144 which should solve the problem

[ghost]

I changed the name of the directory. Thank you.

[sfhacker]

@darkwarrior703 I may be wrong, but ... I don't think it is CMake's fault, but either your broken environment or vcpkg!
CMake works like a charm on my PC. I use it every day to build dozens of projects.

How to build a library without a dependency?

How familiar are you with building projects from source on Windows? A newbie?
If you use CMake, you can add an option like: cmake -Doption_name=OFF ..

[ghost]

I solved the problem. It was from spaces in name. If your directory is "x y", it won't work, because of spaces. "xy" will work.

[NancyLi1013]

Thanks for posting this issue.
Let's wait for the PR #13126 merged to fix this issue.