Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[brotli] build failure #13166

Closed
ghost opened this issue Aug 26, 2020 · 14 comments · Fixed by #13126
Closed

[brotli] build failure #13166

ghost opened this issue Aug 26, 2020 · 14 comments · Fixed by #13126
Assignees
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@ghost
Copy link

ghost commented Aug 26, 2020

Host Environment

  • OS: Windows
  • Compiler: MS VC 2019

To Reproduce
Steps to reproduce the behavior:
./vcpkg install sfml

Failure logs
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
Library "brotlicommon" was not found! If it is a system library use the
SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
correct the *.pc file
Call Stack (most recent call first):
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:298 (vcpkg_fixup_pkgconfig_check_files)
ports/brotli/portfile.cmake:25 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:79 (include)

Error: Building package brotli:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: brotli:x86-windows
Vcpkg version: 2020.06.15-nohash

Additional context
I used git pull and vcpkg install brotli and failed 5 times. I wanted to build sfml, but I haven't manage to deal with brotli.

@Neumann-A
Copy link
Contributor

Without any further debug output I would assume it is the same issue as #13105

@ghost
Copy link
Author

ghost commented Aug 26, 2020

I think that brotli is a dependency for sfml. When I try to install sfml, vcpkg tries to install brotli.

@Neumann-A
Copy link
Contributor

$ ./vcpkg.exe depend-info sfml
zlib:
brotli:
bzip2:
libogg:
libpng: zlib
freetype[bzip2, png]: brotli, bzip2, libpng, zlib
libflac: libogg
libvorbis: libogg
openal-soft:
stb:
sfml: freetype, libflac, libogg, libvorbis, openal-soft, stb

sfml -> freetype -> brotli

@ghost
Copy link
Author

ghost commented Aug 26, 2020

I think there's a problem with CMake because brotlicommon.lib file exists. I checked the directory. How to build a library without a dependency?
Edit: I tried to install other dependency like libogg and the same problem. It isn't a problem with brotli. It's CMake's fault.

@Neumann-A
Copy link
Contributor

I feel like I am being ignored:

Without any further debug output I would assume it is the same issue as #13105

@Neumann-A
Copy link
Contributor

You can tryout PR #13144 which should solve the problem

@ghost
Copy link
Author

ghost commented Aug 26, 2020

I changed the name of the directory. Thank you.

@ghost
Copy link
Author

ghost commented Aug 26, 2020

I solved the problem. It was from spaces in name. If your directory is "x y", it won't work, because of spaces. "xy" will work.

@NancyLi1013 NancyLi1013 self-assigned this Aug 27, 2020
@NancyLi1013 NancyLi1013 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 27, 2020
@NancyLi1013
Copy link
Contributor

Thanks for posting this issue.
Let's wait for the PR #13126 merged to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Neumann-A @NancyLi1013 and others