Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest file not found with msbuild or Visual Studio #14735

Closed
sipsorcery opened this issue Nov 23, 2020 · 3 comments · Fixed by #14772
Closed

Manifest file not found with msbuild or Visual Studio #14735

sipsorcery opened this issue Nov 23, 2020 · 3 comments · Fixed by #14772
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@sipsorcery
Copy link
Contributor

sipsorcery commented Nov 23, 2020

Describe the bug
A clear and concise description of what the bug is.

Environment

  • OS: Windows 10 Pro 10.0.19041
  • Compiler: revision: Visual Studio Community 2019 v16.8.2
    Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64
  • vcpkg checked out form mastercommit ID 097a31d4c3127f38a6fbf4002122550dd9d39b84

To Reproduce
Steps to reproduce the behavior:

  1. Create a new C++ console application using the Visual Studio template.
  2. Open the properties page for the C++ project and enable vcpkg manifests.
  3. Create a vcpkg.json file in the same directory as the project file.
  4. Add the minimal valid manifest contents:
{
  "name": "mypackage",
  "version-string": "0.1.0-dev"
}
  1. Copy the vcpkg.json file to the immediate parent directory (resulting in a copy in the same directory as the project file and its immediate parent).
  2. Click Build.

Expected behavior
The C++ console application to successfully compile.

Failure logs

Build started...
1>------ Build started: Project: CppBuildTest, Configuration: Release x64 ------
1>C:\Tools\vcpkg\scripts\buildsystems\msbuild\vcpkg.targets(47,5): error : The Vcpkg manifest was enabled, but we couldn't find a manifest file (vcpkg.json) in any directories above C:\Users\aaron\source\repos\CppBuildTest. Please add a manifest, disable manifests in your properties page, or pass /p:VcpkgEnableManifest=false.
1>Done building project "CppBuildTest.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Additional context
Reverting to commit ID 40230b8e3f6368dcb398d649331be878ca1e9007 (this is an arbitrary commit ID that was the last time I updated vcpkg) and the vcpkg manifest mechanism works as expected.

@ZhilkinSerg
Copy link

ZhilkinSerg commented Nov 23, 2020

I suspect #12774 has something to do with that Root cause is in #13755 - using latest master and reverting e126e3e fixes the issue.

@JackBoosY
Copy link
Contributor

@strega-nil Can you please take a look?

Thanks.

@strega-nil
Copy link
Contributor

MMh, yeah, I'll fix this today. Thanks @ZhilkinSerg for root-causing this.

strega-nil added a commit to strega-nil/vcpkg that referenced this issue Nov 25, 2020
strega-nil added a commit that referenced this issue Nov 25, 2020
* Fix the issues introduced in 13755

Fixes #14735

* add VcpkgRoot != ''
@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants