-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] x86-windows / x86-windows-static build failure #15351
Comments
generate-x86-windows-dbg-err.log |
Did follow the instructions within the |
@Kwizatz Can you please take a look? Thanks. |
Until recently you had to install the SDK from its standalone installer: https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ though that page seems to imply that you can install it from the VS2019 installer. Try installing it from the standalone SDK installer (winsdksetup.exe), otherwise, make sure you have installed the x86 version of the SDK and not just the x64 SDK. |
It is working for me with the standalone installer, it may be a problem related to the installation path, GN may be looking at the standalone location and not into the VS location of the files at all, I'll keep that in mind for the next update. |
@Kwizatz I think this error message should be reported in portfile.cmake instead of failure logs. |
By default, installing VS 2019 with SDK does not provide an SDK with support for "Debugging Tools for Windows". |
@heretic13 Ahh I see. There is a known issue about Windows SDK: Please download the Windows SDK separately and install it with administrator permission. |
If you make Modify SDK, then the SDK installation does not work |
@heretic13 Have you uninstalled all the Windows SDKs installed using the Visual Studio installer? |
No. It was version 10.0.19041.1 installed via VS Installer. I deleted it. I still have SDK 10.0.17763.0 installed via VS Installer. I cleaned the "buildtrees" folder and removed the previously installed dependency components - icu, zlib. I ran the build and it failed again. generate-x86-windows-static-dbg-err.log Do I have to do something extra to switch vcpkg and VS2019 to use SDK 10.0.17763.0? |
@heretic13, could you reinstall sdk 10.0.17763.0, and see if the issue persist? Please open x64 Native tools command tool and execute the command: 'set include', could you attach the output here? Could you also check if C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x86 still exist in your local machine? |
The situation is as follows. This file "api-ms-win-downlevel-kernel32-l2-1-0.dll" appeared only after I downloaded and manually installed SDK 10.0.19041.1 with support for "Debugging tools for Windows". Now v8 is in the process of building (a few minutes already). Previously, the process has already terminated at this point with an error. Brief conclusions:
|
Compilation successful! |
Agreed, current report comes from upstream GN, so not sure how to trap it from the portfile other that running the same check independently from cmake. |
@Kwizatz Example: vcpkg/ports/winsock2/portfile.cmake Lines 1 to 11 in b7c476b
|
@JackBoosY Thanks, that helps. |
Hi guys, is this issue resolved? |
env
not found v8 in find_package cmake
cmake log
|
This is a different issue than the one described here, were you able to build v8 for the 86-windows-static triplet? how are you trying to configure your project? |
Build v8 normally, but cmake in the project cannot find v8 |
Well, are you properly setting CMAKE_TOOLCHAIN_FILE? are you setting cmake compiler architecture properly? are you disabling shared libraries? it seems to be the case that your project is not finding v8 installed in vcpkg\installed\x86-windows-static as it should be the case. V8Config.cmake should be at vcpkg\installed\x86-windows-static\share\v8 |
The problem of vs. Variables and caches do not take effect. You need to set the command line parameter -DVCPKG_TARGET_TRIPLET=x86-windows-static, but there are new problems, Could NOT find V8 (missing: V8_LIBRARY) (found version "9.0.257.17") |
D:\vcpkg\installed\x86-windows-static\lib There are only icu**.lib and zlib.lib in the directory of D:\vcpkg\installed\x86-windows-static\lib, but not v8**.lib |
That means v8 was not successfully built, if so then build it:
if there's errors... well that's a community triplet not officially supported, but it should work AFAIK. Also having vcpkg on D instead of C might be an issue... or maybe it is not as long as VC itself is not installed on D. |
Hi @JackBoosY yes, you can close this issue, I removed all installed versions of the SDK, did a repair install of VC, changed the installed SDK on console panel to add debug tools, ran a build and it worked. Sorry about the delay, the build taking hours to complete is usually my deterrent 😁. |
I have deleted and retried 3 times, but there is no v8**.lib
|
But there are already successfully built libs in this directory |
Why are you running vcpkg at C:\Users\vsq_k instead of D:\vcpkg? Is VCPKG_ROOT set to anything other than D:\vcpkg? I am sorry, but these issues have more to do with your environment than any problems with the build script itself, I cannot guess at what your full environment is, and without any build error logs I am really running out of ideas here. |
The path environment variable is set, and vcpkg integrate install has been executed. There are no other settings. I will recompile and see. |
D:\vcpkg\ports\v8\vcpkg.json
Why only linux, not windows |
The Windows port does not require pthread or glib. There is no functionality lost AFAIK. |
The cmake project cannot be compiled normally at all, and it still prompts that v8_library is missing |
I found the problem, vcpkg_install_gn is NOT installing the targets, this seems to be true for any triplet. Hi @JackBoosY , do you know if this is a known issue at the moment? |
I've created an issue to track the problem reported by @36k-wild-monkey . |
It's unknown issue. |
@heretic13 Is still work for this issue? Does the problem still exist? |
For FrankXie05. Host Environment OS: Windows 11 21H2 (22000.469), v8 doesn't compile! But I did not make the corrections as advised "StarGate One". |
@heretic13 Thank you for your reply. I found that you have compiled successfully in your discussion. Can you try it with the previous suggestion? :) |
@FrankXie05, Maybe I'll do it later. |
Fixes comments: #15351 (comment) v8 errors regarding the SDK are currently reported from upstream GN, this error message should be reported in portfile.cmake rather than in the failure log. Adding judgment print messages makes it easier to view errors. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~~SHA512s are updated for each updated download.~~ - [ ] ~~The "supports" clause reflects platforms that may be fixed by this new version.~~ - [ ] ~~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~~ - [ ] ~~Any patches that are no longer applied are deleted from the port's directory.~~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. --------- Co-authored-by: Jon <v-zhli17@microsoft.com>
Host Environment
To Reproduce
Steps to reproduce the behavior:
vcpkg.exe install v8:x86-windows-static
or
vcpkg.exe install v8
Failure logs
Additional context
none
The text was updated successfully, but these errors were encountered: