Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libdatachannel] It can find dependent libraries on its own. #18616

Closed
KangLin opened this issue Jun 24, 2021 · 2 comments · Fixed by #18621
Closed

[libdatachannel] It can find dependent libraries on its own. #18616

KangLin opened this issue Jun 24, 2021 · 2 comments · Fixed by #18621
Assignees
@NancyLi1013
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@KangLin
Copy link
Contributor

KangLin commented Jun 24, 2021

My program depends on libdatachannel. Then libdatachannel depends on Threads::Threads and LibJuice::juice.
In my program CMakeLists.txt use:

find_package(libdatachannel)

The error message:
Target "RabbitProxy" links to target "Threads::Threads" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?

Of cause. can to add find_package(Threads).
But my expectation is that it can find dependent libraries on its own.
Is there a way to solve?
@NancyLi1013 NancyLi1013 self-assigned this Jun 24, 2021
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Jun 24, 2021
@NancyLi1013 NancyLi1013 mentioned this issue Jun 24, 2021
Merged
@NancyLi1013 NancyLi1013 changed the title It can find dependent libraries on its own. [libdatachannel] It can find dependent libraries on its own. Jun 24, 2021
@KangLin
Copy link
Contributor Author

KangLin commented Jun 25, 2021

Solution:
See: https://gitlab.kitware.com/cmake/cmake/-/issues/22336

@NancyLi1013
Copy link
Contributor

Thanks for your information @KangLin. I have submitted a PR #18621 to fix this problem.

KangLin added a commit to KangLin/libdatachannel that referenced this issue Jun 25, 2021
@KangLin
FIX Bug: It can find dependent libraries on its own
36d2a60 
See: microsoft/vcpkg#18616
This was referenced Jun 25, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libdatachannel] Fix usage NancyLi1013/vcpkg
2 participants
@KangLin @NancyLi1013