Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Port Request] godot-cpp #34492

Closed
YukiSnowmew opened this issue Oct 14, 2023 · 1 comment · Fixed by #37931
Closed

[New Port Request] godot-cpp #34492

YukiSnowmew opened this issue Oct 14, 2023 · 1 comment · Fixed by #37931
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-resolved This port has been added to vcpkg.

Comments

@YukiSnowmew
Copy link

Library name

godot-cpp

Library description

C++ bindings for the Godot Engine's GDExtensions API

Source repository URL

https://github.com/godotengine/godot-cpp

Project homepage (if different from the source repository)

https://godotengine.org/

Anything else that is useful to know when adding (such as optional features the library may have that should be included)

This library is used to create extensions for the godot game engine. This is not the engine itself. Godot's gdextensions are the new way to extend the engine, allowing us to write game logic in C++ without recompiling the engine. The library is meant to be statically linked into a project.

The library provides a float precision option in the CMakeLists.txt file, which should be supported.

More info about gdextensions

@YukiSnowmew YukiSnowmew added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Oct 14, 2023
@YukiSnowmew YukiSnowmew changed the title [New Port Request] <library name here> [New Port Request] godot-cpp Oct 14, 2023
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Dec 14, 2023
@github-actions github-actions bot added the info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. label Dec 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
@Cheney-W Cheney-W reopened this Apr 16, 2024
@Cheney-W Cheney-W removed info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. Stale labels Apr 16, 2024
vicroms pushed a commit that referenced this issue Jun 8, 2024
Fixes #34492

- [X] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [X] The name of the port matches an existing name for this component
on https://repology.org/ if possible, and/or is strongly associated with
that component on search engines.
- [X] Optional dependencies are resolved in exactly one way. For
example, if the component is built with CMake, all `find_package` calls
are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or
disabled with
[CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html).
- [X] The versioning scheme in `vcpkg.json` matches what upstream says.
- [X] The license declaration in `vcpkg.json` matches what upstream
says.
- [X] The installed as the "copyright" file matches what upstream says.
- [X] The source code of the component installed comes from an
authoritative source.
- [X] The generated "usage text" is accurate. See
[adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md)
for context.
- [X] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [X] Only one version is in the new port's versions file.
- [X] Only one version is added to each modified port's versions file.

Notes:
- This library is static only, so it's only supported for the static
triplets.
- Unfortunately, godot-cpp is not yet installable, so I had to patch its
cmake script.
I have made a PR upstream:
godotengine/godot-cpp#1418
But in the meanwhile, I have created an unofficial export target
`unofficial::godot::cpp`.
@Cheney-W Cheney-W added the info:new-port-resolved This port has been added to vcpkg. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-resolved This port has been added to vcpkg.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants