Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-storage-cpp:x64-linux] linking fails in debug #7311

Closed
crusader-mike opened this issue Jul 17, 2019 · 3 comments
Closed

[azure-storage-cpp:x64-linux] linking fails in debug #7311

crusader-mike opened this issue Jul 17, 2019 · 3 comments

Comments

@crusader-mike
Copy link
Contributor

You end up with bunch of missing symbols related to gcov. Looks like the reason is this line

What is the proper way of addressing this issue? I am not keen on adding -lgcov to my compilation options just because somehow my project ended up being dependent on azure-storage-cpp.

Should I add a patch to azure-storage-cpp port to get rid of -fprofile-arcs -ftest-coverage?

Should I add gcov dependency somewhere in port definition? (where?)
@crusader-mike crusader-mike changed the title linking azure-storage-cpp fails in debug (on Linux) [azure-storage-cpp] linking fails in debug (on Linux) Jul 18, 2019
@crusader-mike
Copy link
Contributor Author

To clarify: I can workaround this, my question is "what is the correct way to address this issue?".

@crusader-mike crusader-mike changed the title [azure-storage-cpp] linking fails in debug (on Linux) [azure-storage-cpp::x64-linux] linking fails in debug Jul 18, 2019
@crusader-mike crusader-mike changed the title [azure-storage-cpp::x64-linux] linking fails in debug [azure-storage-cpp:x64-linux] linking fails in debug Jul 18, 2019
@crusader-mike crusader-mike mentioned this issue Jul 23, 2019
Closed
@vicroms
Copy link
Member

vicroms commented Jul 23, 2019

Hi @crusader-mike

In my opinion it makes sense to remove this kind of instrumentation options from the build.

The right way to do it would be to generate a patch that removes those flags from the CMakeLists.txt and apply said patch in the portfile.

@crusader-mike
Copy link
Contributor Author

@vicroms Thank you. I'll make a PR when I have a chance

@crusader-mike crusader-mike mentioned this issue Jul 24, 2019
Closed
crusader-mike added a commit to crusader-mike/vcpkg that referenced this issue Jul 24, 2019
@crusader-mike
[azure-storage-cpp] Removed gcov dependency in debug Linux build (mic…
6afe916 
…rosoft#7311)
@crusader-mike crusader-mike mentioned this issue Jul 24, 2019
Merged
ras0219-msft pushed a commit that referenced this issue Jul 29, 2019
@crusader-mike @ras0219-msft
[azure-storage-cpp] Removed gcov dependency in debug Linux build (#7311…
1f910f0 
…) (#7404)

* Resolves "project is never up-to-date" problem (issue 6179)

* [azure-storage-cpp] Removed gcov dependency in debug Linux build (#7311)

* [azure-storage-cpp] bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vicroms @crusader-mike