New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libmariadb] Fix patch #10043
[libmariadb] Fix patch #10043
Conversation
/azp run |
I added the commits by myself to my vcpkg folder (in my PC) and tried to rebuild still same error or adding it by myself isn't an option? |
@Moustafa1337 Could you provide failure logs? |
I checked this branch out and tested it; works for me. |
@Moustafa1337 @ainz7892 please pull this branch. |
Still
Error: Building package libmariadb:x64-windows failed with: BUILD_FAILED Additionally, attach any relevant sections from the log files above. |
@Moustafa1337 Could you provide your cmake version? |
cmake version 3.16.4 |
@JackBoosY Applying this patch fixes the issue for me |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Extracting source C:/Users/Adorius Black/vcpkg/downloads/MariaDB-mariadb-connector-c-8e9c3116105d9a998a60991b7f4ba910d454d4b1.tar.gz
-- Applying patch md.patch
CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:50 (message):
Applying patch failed. Patch needs to be updated to work with source being
used by vcpkg!
Call Stack (most recent call first):
scripts/cmake/vcpkg_extract_source_archive_ex.cmake:134 (vcpkg_apply_patches)
scripts/cmake/vcpkg_from_github.cmake:139 (vcpkg_extract_source_archive_ex)
ports/libmariadb/portfile.cmake:8 (vcpkg_from_github)
scripts/ports.cmake:90 (include)
Error: Building package libmariadb:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update
, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libmariadb:x64-windows
Vcpkg version: 2020.02.04-nohash
@Moustafa1337 @NoFr1ends @Derimax3 After installed cmake 3.16.4, I still can't repro that. |
Hello JackBoosY this is log from patch-x86-windows-0-err |
Should I reinstall Cmake? Sorry i am totaly beginner in this. What version should i have? Because i have cmake-3.17.0 . |
@Derimax3 I think it has nothing to do with cmake version. Please provide full log. |
I deleted /buildtrees/libmariadb/src/ and still same error.
|
@ras0219-msft Can you take a look? |
@JackBoosY You maybe misunderstood me but your PR is working for me. |
I have had the same issue when trying to install Can we merge this into |
@Derimax3 Are you sure that you have checked out this PR instead of the master, or at least have applied this PR as a patch to your vcpkg folder? |
Hi how you fixed it ? Can you tell me please? |
You should learn how to use git and GitHub first. |
One more question. How to download it? Just save it in vcpkg as text with name 10043.patch? or should i donwload it in git? Anyway Thank you. You pushed me little bit |
Just download it so you have a file called 10043.patch (or anything else, but then you have to change the git apply command) |
I downloaded it and i did i use this command: git apply 10043.patch error: patch failed: ports/libmariadb/CONTROL:1 |
On which branch are you and are you on the newest version? |
https://github.com/otland/forgottenserver/wiki/Compiling-on-Windows-(vcpkg) |
That wasn't my question.. |
C:\Users\Adorius Black\vcpkg>git pull C:\Users\Adorius Black\vcpkg>git apply 10043.patch Where should i donwload 10043.patch? Desktop,Vcpkg or it doesnt matter? |
In this case you don't even have to bother with applying a PR to your code, simply just download the whole contents of the Because this was basically just what I did when I tested this PR, because after I initially ran into this issue I had fixed it on my own and only after I was done I had the idea to actually look if other people ran into this issue as well and if someone already submitted a PR, which was of course the case. ;-) |
Please follow the steps below:
|
|
There is another way to just switch to a branch that contains exactly the changes of this PR:
This creates a new branch |
Thanks this fixed it for me, other solutions didn't work. |
This looks good! (although I wonder how it ever worked...) Thanks! 😄 |
@strega-nil I just judate the patch. Looking at the changes in detail, you will find that the source code content related to the patch has been changed. |
Shouldn't a test have caught the build failure before it was merged into master? |
@OlafvdSpek Well, obviously the pipeline test didn't catch this regression. |
Wouldn't that be an issue by itself? |
@OlafvdSpek because mariadb clashes with mysql, we don't test it; this is an issue with our current CI system, and will be fixed at some point. Sorry! |
Due to version update, fix outdated patche.
Related: #10024.
Note: this port doesn't contain any features.