Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osg] Add feature examples and plugins, fix configure options #10082

Merged
merged 17 commits into from
Apr 16, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 15, 2020

This PR will:

  • Fix conflicts between dependencies sdl1 and sdl2.
  • Add feature examples.
  • Add feature plugins.
  • Add feature tools.
  • Add feature packages.
  • Add feature docs.

Related: #10051.

Note: All features passed in the following triplets test:

  • x86-windows
  • x64-windows-static

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 15, 2020
@JackBoosY JackBoosY mentioned this pull request Feb 15, 2020
@JackBoosY JackBoosY added the wip label Feb 15, 2020
@JackBoosY JackBoosY marked this pull request as ready for review February 18, 2020 01:02
@JackBoosY JackBoosY removed the wip label Feb 18, 2020
@vicroms
Copy link
Member

vicroms commented Feb 20, 2020

/azp run

1 similar comment
@vicroms
Copy link
Member

vicroms commented Feb 20, 2020

/azp run

@PhoebeHui
Copy link
Contributor

osg:x64-windows-static failed om CI testing.

@vicroms
Copy link
Member

vicroms commented Feb 20, 2020

Fails during post-build validations

There should be no empty directories in C:\vsts\_work\4\s\packages\osg_x64-windows-static
The following empty directories were found:

    C:/vsts/_work/4/s/packages/osg_x64-windows-static/tools/osg

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:

    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")


Found 1 error(s). Please correct the portfile:
    C:\vsts\_work\4\s\ports\osg\portfile.cmake
-- Performing post-build validation done

@JackBoosY
Copy link
Contributor Author

@vicroms I will fix it tomorrow.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 21, 2020
@MVoz
Copy link
Contributor

MVoz commented Mar 2, 2020

CMake Error at ports/osg/portfile.cmake:106 (if):
  if given arguments:

    "NO" "EXISTS" "E:/tools/vcpkg/packages/osg_x64-windows/tools/osg"

  Unknown arguments specified
Call Stack (most recent call first):
  scripts/ports.cmake:90 (include)

ports/osg/portfile.cmake:106 and 121 str

if (NO EXISTS ${OSG_TO -->> if(NOT EXISTS ${OSG_TO ?

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Mar 2, 2020
@JackBoosY
Copy link
Contributor Author

/azp run

@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw dan-shaw removed the info:reviewed Pull Request changes follow basic guidelines label Mar 20, 2020
@dan-shaw
Copy link
Contributor

@JackBoosY It appears that osg-qt is failing

@NancyLi1013
Copy link
Contributor

Related issue #10320

@JackBoosY
Copy link
Contributor Author

@dan-shaw The reasons for the osg-qt build failure is:

CMake Error at /ci/myagent/_work/1/s/installed/x64-linux/share/cmake/Qt5Gui/Qt5GuiConfig.cmake:15 (message):
  The imported target "Qt5::Gui" references the file

     "/ci/myagent/_work/3/s/installed/x64-linux/lib/libEGL.so"

  but this file does not exist.  Possible reasons include:
  * The file was deleted, renamed, or moved to another location.
  * An install or uninstall procedure did not complete successfully.
  * The installation package was faulty and contained

Please note that the path of this library is _/ci/myagent/work/3/s but the current ci test path is _/ci/myagent/work/1/s.
So I guess this is because the library is permanently archived on the pipeline machine, and using the library is provided by cmake file Qt5GuiConfig.cmake, which causes the issue to occur.

Please check on the pipeline machine, we may need to delete the related files on all pipeline machines.

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

@dan-shaw Seems okay now.

@JackBoosY JackBoosY requested a review from dan-shaw April 15, 2020 02:10
@ras0219-msft ras0219-msft merged commit b12256a into microsoft:master Apr 16, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_osg_build branch April 17, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants