Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lz4] Fix for building Linux shared libraries #10452

Merged
merged 2 commits into from Apr 16, 2020

Conversation

here-mikelley
Copy link
Contributor

@here-mikelley here-mikelley commented Mar 18, 2020

Describe the pull request

  • What does your PR fix?

Fixes issue #7223. This pull request allows lz4 to be compiled as a shared object under Linux.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Supports all current triplets

Yes

@Cheney-W
Copy link
Contributor

@here-mikelley
Thanks for your PR!

  1. Could you please update the version in ports/lz4/CONTROL as 1.9.2-1?
  2. include(vcpkg_common_functions) is no longer needed, could you please remove this line?
  3. Could you please modify the line 37 and 38 of ports/lz4/portfile.cmake as below:
    file(INSTALL ${SOURCE_PATH}/lib/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

You can get more information from maintainer-guide.md.

@here-mikelley
Copy link
Contributor Author

Thanks @Cheney-W . I've added a commit that should have all of your requested changes.

@Cheney-W
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui marked this pull request as ready for review March 20, 2020 03:53
@PhoebeHui
Copy link
Contributor

/azp run

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 20, 2020
@dan-shaw
Copy link
Contributor

@here-mikelley I'm not sure what this PR fixes. Can you open an issue/provide an example on what it does?

@dan-shaw dan-shaw added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 28, 2020
@here-mikelley
Copy link
Contributor Author

@here-mikelley I'm not sure what this PR fixes. Can you open an issue/provide an example on what it does?

I've updated my original pull-request description by referencing a previously submitted issue. This pull request allows users to build lz4 as a dynamic library under Linux.

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Mar 31, 2020
@ras0219-msft ras0219-msft merged commit f68088b into microsoft:master Apr 16, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants