Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost-process] Patch for header bug in boost 1.72 #10453

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

d-winsor
Copy link
Contributor

Applies a patch to fix boost-process which is currently broken in 1.72. This is likely to be fixed in 1.73 at which point this patch can be removed.

  • What does your PR fix? Fixes issue #

This fixed issue boostorg/process#116

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets should be supported. Have no updated the CI baseline.

Yes

@NancyLi1013 NancyLi1013 self-assigned this Mar 18, 2020
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?

Could you please also update the version in ports/boost-process/CONTROL file as 1.72.0-1?

@d-winsor
Copy link
Contributor Author

include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?

Could you please also update the version in ports/boost-process/CONTROL file as 1.72.0-1?

Removing include(vcpkg_common_functions) would update every boost port file as they are auto-generated. That means updating every boost port version number. Is that OK or should it be a separate PR?

@dan-shaw
Copy link
Contributor

LGTM, we will probably need to remove the patch from the script for 1.73, but that is fine. There are some unrelated failures in the CI that we are trying to fix which may depend on boost, so we should wait before merging this.

@dan-shaw dan-shaw added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Mar 19, 2020
@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw dan-shaw merged commit e2c671d into microsoft:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants