[opus] Make AVX an optional feature #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linux build failed in an unrelated package? |
Ghabry
changed the title
LilyWangL
suggested changes
Apr 2, 2020
The error on Linux is not related with this PR. |
|
Thanks for the quick feedback, didn't knew about the new feature check func :). |
LilyWangL
approved these changes
Apr 3, 2020
LilyWangL
added
info:reviewed
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes AVX for opus an optional feature as in some other ports (fftw3)
Emtting AVX by default is still problematic, see: EasyRPG/Player#2059
The CPU mentioned in that issue is from 2013. Unfortunately, Intel disabled AVX on there cheaper CPUs :(
I even found a Pentium CPU from 2017 without AVX support: https://ark.intel.com/content/www/de/de/ark/products/97453/intel-pentium-processor-g4600-3m-cache-3-60-ghz.html
(but my workstation with an i5 from 2012 supports it...)
For opus[core]
For opus[avx]