Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ryml] Add new port #10793

Merged
merged 8 commits into from
Apr 23, 2020
Merged

[ryml] Add new port #10793

merged 8 commits into from
Apr 23, 2020

Conversation

vvandrounik
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    N/A
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested (locally): x64/x86-linux, x64/x86-windows (static linkage only).
    No.
  • Does your PR follow the maintainer guide?
    Yes.

ports/ryml/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@LilyWangL
Copy link
Contributor

This port depends on c4core, so waiting for PR #10791 merge.

@LilyWangL LilyWangL marked this pull request as draft April 16, 2020 07:55
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10793 in repo microsoft/vcpkg

@vvandrounik vvandrounik marked this pull request as ready for review April 18, 2020 22:53
@vvandrounik vvandrounik marked this pull request as draft April 18, 2020 22:55
@vvandrounik
Copy link
Contributor Author

Sorry, I have two left hands. I accidentally did merged master branch into ryml and pushed, so I did used force push to overwrite this. 😢

@vvandrounik
Copy link
Contributor Author

I'm should ignore otl regression and update CI baseline?

@LilyWangL
Copy link
Contributor

I'm should ignore otl regression and update CI baseline?

I'm should ignore otl regression and update CI baseline?

This is the CI error, please wait it fixed by other PRs.

@JackBoosY JackBoosY marked this pull request as ready for review April 20, 2020 02:36
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JackBoosY
Copy link
Contributor

The otl regressions(#10922) are not related with this PR.

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Apr 21, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants