Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libvmdk] Initial port #11010

Merged
merged 2 commits into from May 18, 2020
Merged

[libvmdk] Initial port #11010

merged 2 commits into from May 18, 2020

Conversation

VelocityRa
Copy link
Contributor

Based on #6852.

@msftclas
Copy link

msftclas commented Apr 24, 2020 •
edited

CLA assistant check
All CLA requirements met.

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 24, 2020 •
edited

Volumes/data/work/1/s/buildtrees/libvmdk/src/20191221-5d3ea3bc22/libclocale/libclocale_support.c:26:10: fatal error: 'libintl.h' file not found
Volumes/data/work/1/s/buildtrees/libvmdk/src/20191221-5d3ea3bc22/libcfile/libcfile_file.c:67:10: fatal error: 'linux/fs.h' file not found

Why do HAVE_LIBINTL_H and HAVE_LINUX_FS_H get defined on macOS despite their respective headers missing?

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 24, 2020 •
edited

Would patching out the #includes on macOS be accepted if it works?
I don't really know why this happens so I can't implement another solution.

@VelocityRa
Copy link
Contributor Author

Adding gettext to Build-Depends fixed the libintl issue.

@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 6835dc4 to 31debb9 Compare April 25, 2020 15:25
@VelocityRa VelocityRa marked this pull request as ready for review April 25, 2020 15:26
@VelocityRa VelocityRa changed the title [libvmdk] Add new port [libvmdk] Initial port Apr 25, 2020
@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 25, 2020 •
edited

Maintainers, any help? This CI error is unrelated to my PR (happens on macOS).

-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip...
-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
      
      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  ports/geographiclib/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

@VelocityRa VelocityRa mentioned this pull request Apr 25, 2020
Closed
@VelocityRa
Copy link
Contributor Author

Squashed commits.

@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 8831f4a to cfcdd90 Compare April 26, 2020 17:19
@VelocityRa
Copy link
Contributor Author

Done.

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VelocityRa
Copy link
Contributor Author

Tests pass.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY
JackBoosY suggested changes May 9, 2020
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

Pinging @VelocityRa for response. Is work still being done for this PR?

@VelocityRa
Copy link
Contributor Author

the line you told me to delete resulted in CI failing

@VelocityRa
[libvmdk] Initial port
c1b9773 
Signed-off-by: Nick Renieris <velocityra@gmail.com>
@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 2437ffa to c1b9773 Compare May 15, 2020 13:47
@VelocityRa
Copy link
Contributor Author

that's why i had disabled static. it fails with that weird error

JackBoosY
JackBoosY suggested changes May 18, 2020
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2020
@strega-nil
Copy link
Contributor

Alright, this looks good to me! Thanks so much @VelocityRa :)

@strega-nil strega-nil merged commit 9f0f0bd into microsoft:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VelocityRa @msftclas @NancyLi1013 @JackBoosY @strega-nil