[rsocket] Add new port #11021

curoky · 2020-04-25T07:58:48Z

Describe the pull request
C++ implementation of RSocket http://rsocket.io
https://github.com/rsocket/rsocket-cpp

What does your PR fix? Fixes #10705
N/A

Which triplets are supported/not supported? Have you updated the CI baseline?
Not support x64-windows x64-windows-static

Does your PR follow the maintainer guide?
Yes

ports/rsocket/CONTROL

ports/rsocket/portfile.cmake

JackBoosY · 2020-04-26T10:08:12Z

scripts/ci.baseline.txt

@@ -1587,6 +1587,8 @@ rpclib:x64-uwp=fail
 rpclib:x64-windows=ignore
 rpclib:x86-windows=ignore
 rpclib:x64-windows-static=ignore
+rsocket:x64-windows=fail


If this port does not support x64-windows and x64-windows-static, please add vcpkg_fail_port_install(ON_ARCH "x64") to the top of portfile.cmake.

@curoky ,
folly itself according to it's port file supports x64 only (there is restriction in port file) and just mention instability on Windows in CONTROL file. Why not just rely on folly as dependency. If it's available then rsocket-cpp will work.

@curoky , I cannot see explanation of the feature of the CONTROL file ( https://vcpkg.readthedocs.io/en/latest/maintainers/control-files/ )

but folly has
in folly itself I see following in CONTROL file
Supports: x64

In other port I see following (I assume this is some kind of restrictions) which can be usefull

Supports: (windows|linux)&x64
Supports: x86 | x64
Supports: !(windows|arm|uwp)

@curoky ,
according to folly readme windows is actually supported

folly supports gcc (5.1+), clang, or MSVC. It should run on Linux (x86-32, x86-64, and ARM), iOS, macOS, and Windows (x86-64).

I've found related issues

[folly] build failure #9156 windows build worked some time ago

[folly] update to latest #10045 seems at the moment there is some issue with visual studio

I suggest to not restrict platform for rsocket. Just require that folly exists.

ports/rsocket/portfile.cmake

curoky · 2020-04-26T12:46:35Z

Maybe I shouldn't add vcpkg_fail_port_install(ON_ARCH "x64"), it seems that x64 contains linux environment.
I just want skip windows environment.

ports/rsocket/CONTROL

ports/rsocket/portfile.cmake

malirod · 2020-04-29T14:49:17Z

ports/rsocket/fix-cmake-config.patch

@@ -0,0 +1,26 @@
+diff --git a/cmake/rsocket-config.cmake.in b/cmake/rsocket-config.cmake.in


@curoky , can you please explain the purpose of this patch? I've managed to build (at least) latest master under vcpkg without patching. Is there any issues with using lib in target project?

@curoky ,
I've got why this is needed. Maybe it worth to propose such patch to rsocket-cpp itself.

ports/rsocket/CONTROL

curoky · 2020-05-01T08:35:16Z

Thanks for your suggestions @malirod .
The main reason why I compiled this package is that fbthrift depends on this, so all changes are for compiling fbthrift.
I will try my best to solve the above problem. However, I cannot guarantee that the windows can be used since there is no windows environment.

malirod · 2020-05-03T19:27:59Z

@curoky ,
seems folly built fine on linux. there is something wrong with rsocket itself
https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/35961/logs/58

2020-05-02T10:07:45.2960882Z Installing package folly[core,zlib]:x64-windows...
2020-05-02T10:07:45.2961217Z Installing package folly[core,zlib]:x64-windows... done
2020-05-02T10:07:45.2961481Z Elapsed time for package folly:x64-windows: 10.21 s
2020-05-02T10:07:45.2962094Z Starting package 84/84: rsocket:x64-windows
2020-05-02T10:07:45.2962603Z Building package rsocket[core]:x64-windows...
2020-05-02T10:07:45.2963220Z Could not locate cached archive: C:\agent_work\1\s\archives\77\779727562299ee2c6b7f57c07b2704e69734c3d8.zip
2020-05-02T10:08:07.7616776Z -- Downloading https://github.com/rsocket/rsocket-cpp/archive/b237f5dba44bd360ee8c24fb998af83606355116.tar.gz...
2020-05-02T10:08:07.7617845Z -- Extracting source C:/agent/_work/1/s/downloads/rsocket-rsocket-cpp-b237f5dba44bd360ee8c24fb998af83606355116.tar.gz
2020-05-02T10:08:07.7618398Z -- Applying patch fix-cmake-config.patch
2020-05-02T10:08:07.7618746Z -- Using source at C:/agent/_work/1/s/buildtrees/rsocket/src/3606355116-b3d329c9e2
2020-05-02T10:08:07.7619220Z -- Downloading https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-win.zip...
2020-05-02T10:08:07.7620321Z -- Configuring x64-windows
2020-05-02T10:08:07.7620826Z CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
2020-05-02T10:08:07.7621571Z Command failed: ninja -v
2020-05-02T10:08:07.7622458Z Working Directory: C:/agent/_work/1/s/buildtrees/rsocket/x64-windows-rel/vcpkg-parallel-configure
2020-05-02T10:08:07.7622859Z Error code: 1
2020-05-02T10:08:07.7623647Z See logs for more information:
2020-05-02T10:08:07.7624559Z C:\agent_work\1\s\buildtrees\rsocket\config-x64-windows-out.log
2020-05-02T10:08:07.7624845Z
2020-05-02T10:08:07.7625765Z Call Stack (most recent call first):
2020-05-02T10:08:07.7626407Z scripts/cmake/vcpkg_configure_cmake.cmake:297 (vcpkg_execute_required_process)
2020-05-02T10:08:07.7627151Z ports/rsocket/portfile.cmake:16 (vcpkg_configure_cmake)
2020-05-02T10:08:07.7627972Z scripts/ports.cmake:90 (include)
2020-05-02T10:08:07.7628604Z
2020-05-02T10:08:07.7629298Z
2020-05-02T10:08:07.8966038Z Error: Building package rsocket:x64-windows failed with: BUILD_FAILED
2020-05-02T10:08:07.8966823Z Elapsed time for package rsocket:x64-windows: 22.6 s

curoky · 2020-05-04T01:58:39Z

@malirod may need to add the following lines

find_package(ZLIB MODULE REQUIRED)
target_link_libraries(ReactiveSocket ... ZLIB::ZLIB)
target_link_libraries(yarpl ... ZLIB::ZLIB)

Do you have a windows environment? Try it?

-- Found folly: C:/agent/_work/1/s/installed/x64-windows-static
yarpl source dir: C:/agent/_work/1/s/buildtrees/rsocket/src/3606355116-b3d329c9e2/yarpl
-- Configuring done

CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:250 (_add_library):
  Target "ReactiveSocket" links to target "ZLIB::ZLIB" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:205 (add_library)

CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:250 (_add_library):
  Target "yarpl" links to target "ZLIB::ZLIB" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  yarpl/CMakeLists.txt:67 (add_library)

malirod · 2020-05-05T06:17:43Z

@curoky ,
I have win env and I was able to reproduce build issue you've posted. I've added lines you've suggested and managed to pass configuration step. Then there were build issues (see below).
I've playing with the following branch ( https://github.com/malirod/vcpkg/tree/add-port-rsocket-cpp )

Win x63 build issues

Command line warning D9025 : overriding '/std:c++latest' with '/std:c++14'
vcpkg\installed\x64-windows\include\folly/container/detail/F14Mask.h(41): error C3861: '__builtin_ctzll': identifier not found
vcpkg\installed\x64-windows\include\folly/lang/Bits.h(147): error C3861: '__builtin_clzl': identifier not found

Additionally I found following things and propose to add them to this PR

There are recent commits in the rsocket-cpp repo and I see tags so it's possible to set proper version of the port

Version: v2020.05.04.00

Fmt is not mentioned in readme file but it's required in rsocket and yarpl cmake file. So It's required to mention this in CONTROL file.
Build-Depends: folly, fmt, zlib

3.Latest commit and sha

REF 8038d05e741c3d3ecd6adb069b4a1b3daa230e14
    SHA512 d7bc93af7b6130d73fa0823f534ad57a531dfa7d7aa990a2a1a1b72b6761db7eeb60573d0d38f55daa991554e3ab4ac507047f8051a4390b3343cd708a48efbb

Would be great to get feedback about these items.

I'll continue to try to make win build for a while. If you have any ideas how to fix issues please suggest.

JackBoosY

If this port doesn't support x64 triplets.
Please add the following codes to VCPKG_PATH/scripts/ci.baseline.txt:

rsocket:x64-windows=fail
rsocket:x64-windows-static=fail

ports/rsocket/portfile.cmake

ports/rsocket/CONTROL

JackBoosY · 2020-05-08T07:23:14Z

/azp run

azure-pipelines · 2020-05-08T07:23:22Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoebeHui · 2020-05-09T03:20:29Z

/azp run

azure-pipelines · 2020-05-09T03:20:37Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-05-12T06:38:34Z

When used with Visual Studio 2019, folly seems to have a bug.

JackBoosY · 2020-05-15T09:34:54Z

Waiting for #11370 merge and rerun pipeline test.

JackBoosY · 2020-06-09T07:22:33Z

/azp run

azure-pipelines · 2020-06-09T07:22:41Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-06-10T08:23:54Z

When builiding rsocket with x64-windows:

E:\install\x64-windows\include\folly/container/detail/F14Mask.h(39): error C3861: '__builtin_ctz': identifier not found

ports/rsocket/portfile.cmake

ports/rsocket/CONTROL

strega-nil · 2020-07-28T20:52:13Z

/azp run

azure-pipelines · 2020-07-28T20:52:22Z

Azure Pipelines successfully started running 1 pipeline(s).

* [rsocket] Add new port * [rsocket] don't build in some window environment * [rsocket] add missing deps in CONTROL * [rsocket] add missing deps in CONTROL * [rsocket] remove some deprecated args * [rsocket] romove vcpkg_fail_port_install(ON_ARCH x64) * [rsocket] only support x64 architecture * [rsocket] upgrade to 2020.05.04.00 * [rsocket] add vcpkg_fail_port_install to portfile * [rsocket] Fix find dependencies * Update ports/rsocket/portfile.cmake * Update ports/rsocket/CONTROL Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

LilyWangL requested a review from JackBoosY April 26, 2020 02:02

LilyWangL assigned JackBoosY Apr 26, 2020

JackBoosY suggested changes Apr 26, 2020

View reviewed changes

ports/rsocket/CONTROL Outdated Show resolved Hide resolved

JackBoosY suggested changes Apr 26, 2020

View reviewed changes

ports/rsocket/CONTROL Outdated Show resolved Hide resolved

JackBoosY added the waiting for response label Apr 26, 2020

JackBoosY reviewed Apr 26, 2020

View reviewed changes

malirod reviewed Apr 29, 2020

View reviewed changes

malirod mentioned this pull request Apr 29, 2020

[New Port Request] rsocket-cpp #10705

Closed

malirod reviewed Apr 29, 2020

View reviewed changes

ports/rsocket/CONTROL Show resolved Hide resolved

JackBoosY suggested changes May 6, 2020

View reviewed changes

ports/rsocket/portfile.cmake Outdated Show resolved Hide resolved

ports/rsocket/CONTROL Outdated Show resolved Hide resolved

JackBoosY mentioned this pull request May 8, 2020

[libqcow] Update baseline #11238

Merged

JackBoosY removed the waiting for response label May 19, 2020

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 9, 2020

JackBoosY added the requires:author-response label Jun 10, 2020

JackBoosY suggested changes Jun 22, 2020

View reviewed changes

ports/rsocket/portfile.cmake Show resolved Hide resolved

ports/rsocket/CONTROL Show resolved Hide resolved

JackBoosY removed the requires:author-response label Jun 22, 2020

JackBoosY approved these changes Jun 22, 2020

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 22, 2020

curoky and others added 12 commits July 4, 2020 00:42

[rsocket] Add new port

5904e4f

[rsocket] don't build in some window environment

193a8b5

[rsocket] add missing deps in CONTROL

4ea344e

[rsocket] add missing deps in CONTROL

886d11a

[rsocket] remove some deprecated args

5c78f83

[rsocket] romove vcpkg_fail_port_install(ON_ARCH x64)

1abfacf

[rsocket] only support x64 architecture

6d9c492

[rsocket] upgrade to 2020.05.04.00

ce35dd9

[rsocket] add vcpkg_fail_port_install to portfile

1570490

[rsocket] Fix find dependencies

f6d27b5

Update ports/rsocket/portfile.cmake

b0a57d3

Update ports/rsocket/CONTROL

b86c3b4

strega-nil merged commit 62cbf26 into microsoft:master Jul 31, 2020

curoky deleted the add_rsocket branch August 16, 2020 17:38

JackBoosY mentioned this pull request Dec 8, 2021

[rsocket] Remove keyword supports #21911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rsocket] Add new port #11021

[rsocket] Add new port #11021

curoky commented Apr 25, 2020 •

edited by LilyWangL

Loading

JackBoosY Apr 26, 2020

malirod Apr 29, 2020

malirod Apr 29, 2020

malirod May 1, 2020

curoky commented Apr 26, 2020

malirod Apr 29, 2020

malirod May 2, 2020

curoky commented May 1, 2020

malirod commented May 3, 2020

curoky commented May 4, 2020

malirod commented May 5, 2020

JackBoosY left a comment

JackBoosY commented May 8, 2020

azure-pipelines bot commented May 8, 2020

PhoebeHui commented May 9, 2020

azure-pipelines bot commented May 9, 2020

JackBoosY commented May 12, 2020

JackBoosY commented May 15, 2020

JackBoosY commented Jun 9, 2020

azure-pipelines bot commented Jun 9, 2020

JackBoosY commented Jun 10, 2020

strega-nil commented Jul 28, 2020

azure-pipelines bot commented Jul 28, 2020

		@@ -0,0 +1,26 @@
		diff --git a/cmake/rsocket-config.cmake.in b/cmake/rsocket-config.cmake.in

[rsocket] Add new port #11021

[rsocket] Add new port #11021

Conversation

curoky commented Apr 25, 2020 • edited by LilyWangL Loading

JackBoosY Apr 26, 2020

Choose a reason for hiding this comment

malirod Apr 29, 2020

Choose a reason for hiding this comment

malirod Apr 29, 2020

Choose a reason for hiding this comment

malirod May 1, 2020

Choose a reason for hiding this comment

curoky commented Apr 26, 2020

malirod Apr 29, 2020

Choose a reason for hiding this comment

malirod May 2, 2020

Choose a reason for hiding this comment

curoky commented May 1, 2020

malirod commented May 3, 2020

curoky commented May 4, 2020

malirod commented May 5, 2020

JackBoosY left a comment

Choose a reason for hiding this comment

JackBoosY commented May 8, 2020

azure-pipelines bot commented May 8, 2020

PhoebeHui commented May 9, 2020

azure-pipelines bot commented May 9, 2020

JackBoosY commented May 12, 2020

JackBoosY commented May 15, 2020

JackBoosY commented Jun 9, 2020

azure-pipelines bot commented Jun 9, 2020

JackBoosY commented Jun 10, 2020

strega-nil commented Jul 28, 2020

azure-pipelines bot commented Jul 28, 2020

curoky commented Apr 25, 2020 •

edited by LilyWangL

Loading