New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idevicerestore] Fix libgen.h cannot be found #11074
[idevicerestore] Fix libgen.h cannot be found #11074
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Why does this PR cause libidevicerestore to fail on linux and osx? |
Indeed, it seems most important for this port to work on MacOS (given that it is a firmware restoration bit for iOS development). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the concerns pointed out by @ras0219-msft @BillyONeal, this needs more work; could you look at it after your holiday? Thanks!
Hi all, Since
If we want to support Linux and OSX, we should fix the issue for |
how was it working before, then, on the CI? |
I just added
It should not be working on linux and osx before this, which will be blocked by If necessary, I will remove the messages I added and try to build it again. |
mmh, okay, I see. Alright, I think this is good then :) |
Thanks @NancyLi1013 for pushing this forward! |
idevicerestore
build error on x86-windows due tolibgen.h
cannot be found.Related PR #11003
Note: No feature needs to test.