Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencv4] Changed dependency on qt5 to qt5-base, closes microsoft/vcpkg#11138 #11201

Merged
merged 4 commits into from
May 8, 2020

Conversation

venabled
Copy link
Contributor

@venabled venabled commented May 6, 2020

Resolves the circular dependency causing CASCADED_DUE_TO_MISSING_DEPENDENCIES identified by @cenit in #11138 by changing the dependency of the qt feature from qt5 to qt5-base

@NancyLi1013
Copy link
Contributor

Hi @venabled
Thanks for this PR.
Could you please bump the version 4.1.1-4 as 4.1.1-5?

Note: This has been updated in PR #11130.

@BillyONeal
Copy link
Member

@NancyLi1013 I assume you meant bump -1 to -2 ? There's no -4 here...

@cenit
Copy link
Contributor

cenit commented May 7, 2020

can you please do the same change also in opencv3 and opencv2 packages?

@cenit
Copy link
Contributor

cenit commented May 7, 2020

@NancyLi1013 I assume you meant bump -1 to -2 ? There's no -4 here...

opencv is the metapackage. It should be better to update the version of the opencv4 package too...

@NancyLi1013
Copy link
Contributor

@BillyONeal and @cenit

I meant we also needed to update the version for opencv4, which is 4.1.1-4 now.

@BillyONeal
Copy link
Member

Somehow I missed the 4 :)

@venabled
Copy link
Contributor Author

venabled commented May 7, 2020

@BillyONeal bumped the version in opencv4, I made @cenit suggestion to make the same mods to opencv3

@cenit
Copy link
Contributor

cenit commented May 7, 2020

If you merge your PR with master you can apply the same mod also to opencv2

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 8, 2020
@strega-nil
Copy link
Contributor

Cools, thanks @venabled :)

@strega-nil strega-nil merged commit 58560e5 into microsoft:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants