-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeglut] updated to 3.2.1 #11423
[freeglut] updated to 3.2.1 #11423
Conversation
@NancyLi1013 done |
LGTM, thanks for this PR @isanych . |
@isanych what's up with the |
@strega-nil you right, it is still there, just has to be enabled |
@isanych do you know what's wrong with x64_windows_static here? looks like a file rename failed with file not found? |
@strega-nil with FREEGLUT_REPLACE_GLUT set both static and dynamic versions are called just glut and renaming is not needed anymore. vcpkg hopefully will be ok now, but to properly test unknown upstream changes it would be good to have small test project for each port which uses produced library - and if CI would build and run these binaries, it would give more confidence that changes are not breaking much. For now it would be nice to get a notification with results when CI finish building. |
looking at glui |
Cool, thanks so much @isanych :) |
freeglut on master is not building with gcc 10, updated to latest version, fixed gcc 10 issues.