Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeglut] updated to 3.2.1 #11423

Merged
merged 8 commits into from
May 21, 2020
Merged

[freeglut] updated to 3.2.1 #11423

merged 8 commits into from
May 21, 2020

Conversation

isanych
Copy link
Contributor

@isanych isanych commented May 18, 2020

freeglut on master is not building with gcc 10, updated to latest version, fixed gcc 10 issues.

ports/freeglut/portfile.cmake Outdated Show resolved Hide resolved
ports/freeglut/portfile.cmake Outdated Show resolved Hide resolved
ports/freeglut/portfile.cmake Show resolved Hide resolved
@isanych
Copy link
Contributor Author

isanych commented May 19, 2020

@NancyLi1013 done

@isanych isanych requested a review from NancyLi1013 May 20, 2020 07:50
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 20, 2020
@NancyLi1013
Copy link
Contributor

LGTM, thanks for this PR @isanych .

@strega-nil
Copy link
Contributor

@isanych what's up with the glut.h file? Shouldn't that be shipped with glut?

@isanych
Copy link
Contributor Author

isanych commented May 20, 2020

@strega-nil you right, it is still there, just has to be enabled

@strega-nil
Copy link
Contributor

@isanych do you know what's wrong with x64_windows_static here? looks like a file rename failed with file not found?

@isanych
Copy link
Contributor Author

isanych commented May 20, 2020

@strega-nil with FREEGLUT_REPLACE_GLUT set both static and dynamic versions are called just glut and renaming is not needed anymore. vcpkg hopefully will be ok now, but to properly test unknown upstream changes it would be good to have small test project for each port which uses produced library - and if CI would build and run these binaries, it would give more confidence that changes are not breaking much.

For now it would be nice to get a notification with results when CI finish building.

@isanych
Copy link
Contributor Author

isanych commented May 20, 2020

looking at glui

@strega-nil
Copy link
Contributor

Cool, thanks so much @isanych :)

@strega-nil strega-nil merged commit 96edc8c into microsoft:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants