Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtk] Fix single configuration builds #11643

Merged
merged 2 commits into from Jun 1, 2020
Merged

[vtk] Fix single configuration builds #11643

merged 2 commits into from Jun 1, 2020

Conversation

JackBoosY
Copy link
Contributor

Fixes #11641.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 29, 2020
@JackBoosY JackBoosY marked this pull request as ready for review May 29, 2020 09:06
@JackBoosY JackBoosY requested a review from PhoebeHui May 29, 2020 09:19
@Neumann-A
Copy link
Contributor

Should be renamed to: Fix single configuration builds.

@JackBoosY JackBoosY changed the title [vtk] Improve portfile.cmake [vtk] Fix single configuration builds Jun 1, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2020
@dan-shaw dan-shaw merged commit c6414b1 into microsoft:master Jun 1, 2020
@JackBoosY JackBoosY deleted the dev/jack/improve_vtk_20200529 branch June 2, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vtk build failure when VCPKG_BUILD_TYPE=release
4 participants
@JackBoosY @Neumann-A @PhoebeHui @dan-shaw