-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Rename the msbuild property VcpkgRoot #11653
Conversation
…dDir, and set VcpkgRoot to the expected root instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, were there really no other uses of VcpkgRoot
anywhere?
@@ -61,9 +61,6 @@ namespace vcpkg::Export | |||
{ | |||
return Strings::format(R"###( | |||
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
<PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't have to export this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file imported is $/scripts/buildsystems/msbuild/vcpkg.targets
so the vcpkg root is already known from that. It might be an optimization to set the path here but I don't want to significantly change function if I don't have to.
Correct. |
…dDir, and set VcpkgRoot to the expected root instead. (microsoft#11653)
… to VcpkgCurrentInstalledDir, and set VcpkgRoot to the expected root instead.