[ompl]: upgrade to 1.5.0 #11737

mamoll · 2020-06-03T07:04:33Z

Describe the pull request

What does your PR fix?

upgrade OMPL port to latest version

Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?

yes

NancyLi1013

Could you please also bump the version in CONTROL file?

mamoll · 2020-06-04T04:51:21Z

Could you please also bump the version in CONTROL file?

Done!

ports/ompl/CONTROL

NancyLi1013 · 2020-06-05T02:24:20Z

The feature app has passed on x86-windows and x64-windows.

But it build failed on x64-windows-static:

Could you please try to look into this?

[195/196] cmd.exe /C "cd . && F:\11737\vcpkg\downloads\tools\cmake-3.17.2-windows\cmake-3.17.2-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=benchmark\CMakeFiles\ompl_benchmark.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\link.exe  benchmark\CMakeFiles\ompl_benchmark.dir\CFGBenchmark.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkOptions.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkTypes.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\benchmark.cpp.obj  /out:bin\ompl_benchmark.exe /implib:benchmark\ompl_benchmark.lib /pdb:bin\ompl_benchmark.pdb /version:0.0  /machine:x64 /debug /INCREMENTAL /subsystem:console -LIBPATH:F:\11737\vcpkg\installed\x64-windows-static\lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib  opengl32.lib  glu32.lib  assimp-vc141-mt.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib  ompl\src\ompl\ompl.lib  src\omplapp\ompl_app_base.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib  opengl32.lib  glu32.lib  assimp-vc141-mt.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\ccd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomap.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomath.lib  ompl\src\ompl\ompl.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
FAILED: bin/ompl_benchmark.exe 
cmd.exe /C "cd . && F:\11737\vcpkg\downloads\tools\cmake-3.17.2-windows\cmake-3.17.2-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=benchmark\CMakeFiles\ompl_benchmark.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\link.exe  benchmark\CMakeFiles\ompl_benchmark.dir\CFGBenchmark.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkOptions.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkTypes.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\benchmark.cpp.obj  /out:bin\ompl_benchmark.exe /implib:benchmark\ompl_benchmark.lib /pdb:bin\ompl_benchmark.pdb /version:0.0  /machine:x64 /debug /INCREMENTAL /subsystem:console -LIBPATH:F:\11737\vcpkg\installed\x64-windows-static\lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib  opengl32.lib  glu32.lib  assimp-vc141-mt.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib  ompl\src\ompl\ompl.lib  src\omplapp\ompl_app_base.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib  opengl32.lib  glu32.lib  assimp-vc141-mt.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\ccd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomap.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomath.lib  ompl\src\ompl\ompl.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib  F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\link.exe benchmark\CMakeFiles\ompl_benchmark.dir\CFGBenchmark.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkOptions.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\BenchmarkTypes.cpp.obj benchmark\CMakeFiles\ompl_benchmark.dir\benchmark.cpp.obj /out:bin\ompl_benchmark.exe /implib:benchmark\ompl_benchmark.lib /pdb:bin\ompl_benchmark.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console -LIBPATH:F:\11737\vcpkg\installed\x64-windows-static\lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib opengl32.lib glu32.lib assimp-vc141-mt.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib ompl\src\ompl\ompl.lib src\omplapp\ompl_app_base.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_program_options-vc140-mt-gd.lib opengl32.lib glu32.lib assimp-vc141-mt.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\fcl.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\ccd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomap.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\octomath.lib ompl\src\ompl\ompl.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_serialization-vc140-mt-gd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_filesystem-vc140-mt-gd.lib F:\11737\vcpkg\installed\x64-windows-static\debug\lib\boost_system-vc140-mt-gd.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:benchmark\CMakeFiles\ompl_benchmark.dir/intermediate.manifest benchmark\CMakeFiles\ompl_benchmark.dir/manifest.res" failed (exit code 1120) with the following output:
Microsoft (R) Incremental Linker Version 14.16.27040.0
Copyright (C) Microsoft Corporation.  All rights reserved.

assimp-vc141-mt.lib(Importer.cpp.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in CFGBenchmark.cpp.obj
assimp-vc141-mt.lib(Importer.cpp.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in CFGBenchmark.cpp.obj

mamoll · 2020-06-05T03:36:14Z

This seems to be an issue in the assimp library, not ompl itself. Are there other ports that successfully link against assume?

NancyLi1013 · 2020-06-05T07:10:54Z

Currently, there is only magnum-plugins that depends on assimp in vcpkg. I try to install the feature assimpimporter and it can link successfully.
So you might need to look into this.

mamoll · 2020-06-07T04:49:52Z

Sorry, I am too unfamiliar with windows dev to tackle this. I can comment out the app feature. Maybe someone else can provide a proper fix and reenable this feature in a separate PR? If that sounds ok, I push another commit for that.

NancyLi1013 · 2020-06-09T09:57:56Z

Hi @mamoll
Seems to be some problem with assimp and we need to fix it first.

ras0219-msft · 2020-07-13T20:36:59Z

/azp run

azure-pipelines · 2020-07-13T20:37:08Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-08-04T08:25:20Z

@mamoll
Could you please resolve the conflicts?

mamoll · 2020-08-05T21:36:17Z

@mamoll
Could you please resolve the conflicts?

Fixed.

ports/ompl/CONTROL

ports/ompl/portfile.cmake

NancyLi1013 · 2020-08-07T08:49:52Z

Please also test the feature and help confirm if it can work fine.

NancyLi1013 · 2020-08-14T08:21:33Z

/azp run

azure-pipelines · 2020-08-14T08:21:42Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-08-18T01:46:23Z

I test the feature again based on both this PR and master branch. It failed with the same error as before on this PR. For master branch, it failed with anther reason. I will try to rebuild on the same machine with the latest master branch.

I will update the results here after double checking this.

NancyLi1013 · 2020-08-18T06:20:26Z

Confirmed. This error is not related with the changes in this PR.

In my opinion, it doesn't block this PR to be merged. Maybe we need to fix this later.
@mamoll thanks for your efforts and patience.

LGTM now.

BillyONeal · 2020-08-18T16:57:40Z

Thanks for your contribution!

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

[ompl]: upgrade to 1.5.0

f9fd511

NancyLi1013 self-assigned this Jun 3, 2020

windows line endings

c9536fe

NancyLi1013 reviewed Jun 4, 2020

View reviewed changes

NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 4, 2020

update version number in CONTROL file

25b2022

NancyLi1013 approved these changes Jun 4, 2020

View reviewed changes

NancyLi1013 reviewed Jun 4, 2020

View reviewed changes

ports/ompl/CONTROL Outdated Show resolved Hide resolved

Update ports/ompl/CONTROL

bcd8230

NancyLi1013 removed the requires:author-response label Jun 4, 2020

NancyLi1013 added the requires:author-response label Jun 5, 2020

JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Jun 10, 2020

ras0219-msft approved these changes Jul 13, 2020

View reviewed changes

NancyLi1013 added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 4, 2020

Merge branch 'master' into ompl-1.5.0

bff9524

NancyLi1013 suggested changes Aug 6, 2020

View reviewed changes

ports/ompl/CONTROL Outdated Show resolved Hide resolved

ports/ompl/portfile.cmake Outdated Show resolved Hide resolved

ports/ompl/portfile.cmake Outdated Show resolved Hide resolved

small fixes

b251b4e

NancyLi1013 approved these changes Aug 12, 2020

View reviewed changes

NancyLi1013 added the requires:testing Needs tests added before merging label Aug 14, 2020

NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response requires:testing Needs tests added before merging labels Aug 18, 2020

BillyONeal merged commit 739209b into microsoft:master Aug 18, 2020

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020

[ompl]: upgrade to 1.5.0 (microsoft#11737)

bd05ae7

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ompl]: upgrade to 1.5.0 #11737

[ompl]: upgrade to 1.5.0 #11737

mamoll commented Jun 3, 2020

NancyLi1013 left a comment

mamoll commented Jun 4, 2020

NancyLi1013 commented Jun 5, 2020

mamoll commented Jun 5, 2020 •

edited

Loading

NancyLi1013 commented Jun 5, 2020

mamoll commented Jun 7, 2020

NancyLi1013 commented Jun 9, 2020

ras0219-msft commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

NancyLi1013 commented Aug 4, 2020

mamoll commented Aug 5, 2020

NancyLi1013 commented Aug 7, 2020

NancyLi1013 commented Aug 14, 2020

azure-pipelines bot commented Aug 14, 2020

NancyLi1013 commented Aug 18, 2020 •

edited

Loading

NancyLi1013 commented Aug 18, 2020

BillyONeal commented Aug 18, 2020

[ompl]: upgrade to 1.5.0 #11737

[ompl]: upgrade to 1.5.0 #11737

Conversation

mamoll commented Jun 3, 2020

NancyLi1013 left a comment

Choose a reason for hiding this comment

mamoll commented Jun 4, 2020

NancyLi1013 commented Jun 5, 2020

mamoll commented Jun 5, 2020 • edited Loading

NancyLi1013 commented Jun 5, 2020

mamoll commented Jun 7, 2020

NancyLi1013 commented Jun 9, 2020

ras0219-msft commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

NancyLi1013 commented Aug 4, 2020

mamoll commented Aug 5, 2020

NancyLi1013 commented Aug 7, 2020

NancyLi1013 commented Aug 14, 2020

azure-pipelines bot commented Aug 14, 2020

NancyLi1013 commented Aug 18, 2020 • edited Loading

NancyLi1013 commented Aug 18, 2020

BillyONeal commented Aug 18, 2020

mamoll commented Jun 5, 2020 •

edited

Loading

NancyLi1013 commented Aug 18, 2020 •

edited

Loading