Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcpkg android toolchain so it adds flags that aren't just ignored #12097

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

jamiebk
Copy link
Contributor

@jamiebk jamiebk commented Jun 25, 2020

(cherry picked from commit 497fe8ab805bcafd2cb2abd538db8783f897f9ad)

Fixes #12064

(cherry picked from commit 497fe8ab805bcafd2cb2abd538db8783f897f9ad)
@ghost
Copy link

ghost commented Jun 25, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY self-assigned this Jun 28, 2020
@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:reviewed Pull Request changes follow basic guidelines labels Jun 28, 2020
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

@strega-nil Ready to merge.

@strega-nil strega-nil merged commit a17543d into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
(cherry picked from commit 497fe8ab805bcafd2cb2abd538db8783f897f9ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
4 participants