[geos] Update to 3.8.1

[oskaritimperi]

Describe the pull request

• What does your PR fix?

Update geos to 3.8.1

• Which triplets are supported/not supported? Have you updated the CI baseline?

No changes to triplet support I think.

• Does your PR follow the maintainer guide?

It should.

[PhoebeHui]

Thanks for the PR! I guess this PR ready for review.

[oskaritimperi]

Hi, I cant take a look at this for a couple of weeks as I'm on vacation. BR, Oskari

________________________________ From: Robert Schumacher <notifications@github.com> Sent: maanantai 6. heinäkuuta 2020 23.34 To: microsoft/vcpkg Cc: Oskari Timperi; Author Subject: Re: [microsoft/vcpkg] [geos] Update to 3.8.1 (#12163) @ras0219-msft requested changes on this pull request.

________________________________ In ports/geos/static-lib-prefix.patch:

@@ -0,0 +1,26 @@

+diff --git a/CMakeLists.txt b/CMakeLists.txt +index b78ca54b..26778c83 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -228,6 +228,10 @@ if(BUILD_SHARED_LIBS) + + set_target_properties(geos PROPERTIES VERSION ${GEOS_VERSION}) + set_target_properties(geos PROPERTIES SOVERSION ${GEOS_VERSION}) ++else() ++ if(WIN32) ++ set_target_properties(geos PROPERTIES PREFIX lib) Why is this needed? Ideally, the static libraries and the import libraries will have the same name (see the maintainer guide[1]). If there are downstream ports that break when only the dynamic names are provided, they should be patched instead to use the CMake targets. [1] https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-rename-binaries-outside-the-names-given-by-upstream — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[oskaritimperi]

@PhoebeHui Can I somehow run the CI again as the build errors seems to be something that I cannot control? For example The windows build:

Downloading powershell-core...
 https://github.com/PowerShell/PowerShell/releases/download/v6.2.1/PowerShell-6.2.1-win-x86.zip -> D:\downloads\PowerShell-6.2.1-win-x86.zip
WinHttpReceiveResponse() failed: 12152
##[error]Convert-Path : Cannot find path 'C:\agent\_work\1\a\xml-results\x64-windows.xml' because it does not exist.

[oskaritimperi]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 12163 in repo microsoft/vcpkg

[PhoebeHui]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[PhoebeHui]

@oswjk, the failures doesn't relate to your changes, please ignore it, I have rerun the CI testing.

[ras0219]

Because this modifies gdal, libspatialite, and spatialite-tools, those ports all need to have their Port-Version: incremented (or introduced and set to 1 if they don't have one).

Otherwise, LGTM

[oskaritimperi]

Merged master as soil was failing.