Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] print list in json #12179

Merged
merged 6 commits into from
Jul 17, 2020
Merged

[vcpkg] print list in json #12179

merged 6 commits into from
Jul 17, 2020

Conversation

dan-shaw
Copy link
Contributor

Adds a --json flag to vcpkg list so that it will print the list in json.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Jul 1, 2020
ras0219
ras0219 approved these changes Jul 1, 2020
View reviewed changes
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft marked this pull request as draft July 8, 2020 22:19
@strega-nil strega-nil self-requested a review July 9, 2020 21:11
strega-nil
strega-nil suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains UB in a branch 😱

toolsrc/src/vcpkg/commands.list.cpp Show resolved Hide resolved
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/commands.list.cpp Outdated Show resolved Hide resolved
@dan-shaw dan-shaw marked this pull request as ready for review July 16, 2020 23:50
@dan-shaw dan-shaw merged commit 751fc62 into microsoft:master Jul 17, 2020
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 11, 2020
@dan-shaw @remz1337
[vcpkg] print list in json (microsoft#12179)
add3964 
* print list command in json

* fix spacing

* remove reference

* review

* fixes based on review
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@dan-shaw
[vcpkg] print list in json (microsoft#12179)
9cfe207 
* print list command in json

* fix spacing

* remove reference

* review

* fixes based on review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@ras0219-msft ras0219-msft ras0219-msft left review comments

@ras0219 ras0219 ras0219 approved these changes

@strega-nil strega-nil strega-nil approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dan-shaw @ras0219 @BillyONeal @strega-nil @ras0219-msft @PhoebeHui @JackBoosY