Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add vcpkg export to E2E tests. Enable E2E tests on all platforms. #12198

Merged
merged 6 commits into from
Aug 10, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jul 1, 2020

See title.

In order to enable compartmentalized testing, also adds vcpkg export --output-dir=/export/artifacts/. This is implemented for all first-party export mechanisms, however I have declined to implement it for experimental community export mechanisms because we do not have reliable testing for them.

@ras0219 ras0219 force-pushed the dev/roschuma/test-export branch 3 times, most recently from bb22dcb to 17a7551 Compare July 1, 2020 20:38
@ras0219 ras0219 marked this pull request as draft July 1, 2020 20:43
@ras0219 ras0219 force-pushed the dev/roschuma/test-export branch 2 times, most recently from 5c9c867 to 19ddebe Compare July 1, 2020 21:01
@ras0219 ras0219 marked this pull request as ready for review July 1, 2020 23:13
@PhoebeHui PhoebeHui self-assigned this Jul 2, 2020
@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Jul 3, 2020
@BillyONeal
Copy link
Member

Don't forget to remove new vcpkg_downloads references when resolving the merge

@BillyONeal
Copy link
Member

@ras0219 @ras0219-msft @strega-nil e2e99d0 contains 'interesting' merge conflict resolutions from #12314

Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the one thing; also, do variables automagically get turned into environment variables?

toolsrc/src/vcpkg/base/files.cpp Show resolved Hide resolved
@BillyONeal
Copy link
Member

I'm curious about the one thing; also, do variables automagically get turned into environment variables?

Yes: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch

System and user-defined variables also get injected as environment variables for your platform. When variables are turned into environment variables, variable names become uppercase, and periods turn into underscores. For example, the variable name any.variable becomes the variable name $ANY_VARIABLE.

@strega-nil strega-nil merged commit 481738b into microsoft:master Aug 10, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…forms. (microsoft#12198)

* [vcpkg] Add `vcpkg export` to E2E tests. Enable E2E tests on MacOS.

* [vcpkg] Fix export --raw --output-dir=/path/ by changing directory to new export root

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants