Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix #9955 #12201

Merged
merged 1 commit into from
Jul 2, 2020
Merged

[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix #9955 #12201

merged 1 commit into from
Jul 2, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jul 1, 2020

This PR fixes #9955, however it does not introduce a way to ensure this is maintainable long term.

Tested using docker with centos:7:

yum install centos-release-scl
yum install devtoolset-8
scl enable devtoolset-8 bash
./bootstrap-vcpkg.sh

@ras0219 ras0219 mentioned this pull request Jul 1, 2020
Closed
@PhoebeHui PhoebeHui self-assigned this Jul 2, 2020
@ras0219-msft ras0219-msft merged commit a218d0e into microsoft:master Jul 2, 2020
@ras0219-msft ras0219-msft mentioned this pull request Jul 2, 2020
Open
E452003 added a commit to E452003/vcpkg that referenced this pull request Jul 6, 2020
@E452003
Merge branch 'master' of https://github.com/microsoft/vcpkg
723ee5b 
* 'master' of https://github.com/microsoft/vcpkg: (1418 commits)
  [vcpkg integrate] Clean up vcpkg.target file (microsoft#4608)
  [vcpkg_from_sourceforge] Add retry mirror function (2/2) (microsoft#12018)
  [pcre2] Restore the https://ftp.pcre.org/ mirror in addition to the SourceForge mirrors. (microsoft#12233)
  [xercesc] rename feature from xmlch_wchar to xmlch-wchar (microsoft#12205)
  [safeint] Update to 3.24 (microsoft#12217)
  [vcpkg] Remove the tombstones and 'ignore' baseline concepts. (microsoft#12197)
  [msbuild] Revert the importance to Normal (microsoft#12212)
  [vtk] Added opengl feature. (microsoft#11399)
  [span-lite] Update to 0.7.0 (microsoft#12206)
  [cmocka libarchive libiconv libpq libxml2 plibsys] fix drive-by error in vcpkg-cmake-wrappers (microsoft#12196)
  [azure-iot-sdk-c] Fix feature name and enable to build (microsoft#12209)
  [vcpkg] Improve performance of compiler tracking by suppressing aspects of CMake's compiler detection. (microsoft#12203)
  [vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix microsoft#9955 (microsoft#12201)
  [sqlite3] update to 3.32.3 to deal with security issues (microsoft#12185)
  [infoware] Bump version to 0.5.4 (microsoft#12167)
  [imgui] Update to 1.77 (microsoft#12155)
  [vcpkg] Update message in bootstrap.ps1 (microsoft#12145)
  [vcpkg] Enable NuGet-based binary caching via mono (microsoft#12170)
  Don't change manifest root when manifest isn't enabled. (microsoft#12191)
  Fix sourceparagraph:BooleanField (microsoft#12192)
  ...
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@ras0219 @ras0219-msft
[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix micr…
18fa4b2 
…osoft#9955 (microsoft#12201)

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bootstrap failed to build on Centos (devtoolset-7, 8)
4 participants
@ras0219 @vicroms @ras0219-msft @PhoebeHui