Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ogre] Update to version 1.12.7 and fix link error #12210

Merged
merged 6 commits into from
Jul 31, 2020
Merged

[ogre] Update to version 1.12.7 and fix link error #12210

merged 6 commits into from
Jul 31, 2020

Conversation

LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Jul 2, 2020 •
edited
Loading

Describe the pull request

  • What does your PR fix? Fixes [ogre] install ogre after sdl2 make error #12054
    Update ogre to version 1.12.7 and fix link error. The feature ogre[d3d9] build failed on master, other features test pass on x86-windows.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    No
  • Does your PR follow the maintainer guide?
    Yes

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jul 2, 2020
@LilyWangL LilyWangL marked this pull request as ready for review July 2, 2020 10:18
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines requires:discussion labels Jul 3, 2020
ras0219-msft
ras0219-msft requested changes Jul 6, 2020
View reviewed changes
ports/ogre/fix-dependency.patch Outdated Show resolved Hide resolved
ports/ogre/CONTROL Outdated Show resolved Hide resolved
ports/imgui/CMakeLists.txt Outdated Show resolved Hide resolved
ports/imgui/CMakeLists.txt Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed info:reviewed Pull Request changes follow basic guidelines requires:discussion labels Jul 7, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 8, 2020
ras0219-msft
ras0219-msft requested changes Jul 9, 2020
View reviewed changes
ports/ogre/fix-findimgui.patch Outdated Show resolved Hide resolved
@strega-nil strega-nil merged commit 32b7ad0 into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@LilyWangL @strega-nil @hellozee
[ogre] Update to version 1.12.7 and fix link error (microsoft#12210)
2f5365b 
* [ogre] Update to version 1.12.7 and fix link error

* [ogre] Fix find imgui

* [ogre] Fix find imgui

* [ogre] Add vcpkg.json

* format manifest

Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
This was referenced Oct 11, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ogre] install ogre after sdl2 make error
5 participants
@LilyWangL @ras0219-msft @NancyLi1013 @JackBoosY @strega-nil