oat++ suite bump to version 1.1

[mheyman]

Oat++ suite bump to version 1.1

Oat++ bumped to version 1.1 in mid May. We've been using the core, websockets, and swagger for a month on both Windows and Linux with no issues.

[NancyLi1013]

The failures on x86-windows, x64-windows, x64-windows-static are like this:

-- Configuring done
CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:326 (_add_library):
  Target "oatpp-mbedtls" links to target "mbedtls::TLS" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:2 (add_library)


CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:326 (_add_library):
  Target "oatpp-mbedtls" links to target "mbedtls::X509" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:2 (add_library)


CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:326 (_add_library):
  Target "oatpp-mbedtls" links to target "mbedtls::Crypto" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:2 (add_library)

[NancyLi1013]

Please also look into the regressions and try to fix them.

[mheyman]

The latest code has a change in case for a find_package() that was not failing on my build but seemed to be the issue on yours. We'll see ;-)

[NancyLi1013]

I will try to reproduce this on my local.

[NancyLi1013]

It seems to be related with case sensitive.

I noticed that it used if(MBEDTLS_FOUND) in
cmake/module/Findmbedtls.cmake .

But from the configure log, I found the info is:
-- Found mbedTLS: D:/installed/x64-windows/include (found version "2.16.3")

So could you please try to update MBEDTLS_FOUND as mbedTLS_FOUND and rebuild this on CI?

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BillyONeal]

PR validation still looks like legit failures

[NancyLi1013]

@mheyman
Is work still being done for this PR?

[mheyman]

I still want to be able to use oatpp from github vcpkg. Been too busy to do more. I have to tell you that we've been using it from our own fork of vcpkg for a while on both windows and linux and haven't been able to reproduce the issues it has been having building on your servers and it is hard to debug (or at least requires arcane knowledge I don't posses). Is there a faq or other document somewhere listing common steps to take when your code builds without a problem locally but fails in the azure system you are using? Thanks

…

On Wed, Aug 26, 2020 at 10:37 PM NancyLi1013 ***@***.***> wrote: @mheyman <https://github.com/mheyman> Is work still being done for this PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJT7J4G5CH3OYZHVKE2EWDSCXBHFANCNFSM4OPVKTVQ> .

[mheyman]

I think I finally figured out what was going on - there is a version of FindMbedtls.cmake somewhere on the Azure build servers that doesn't exist in our systems. Cmake calls that find code instead of the one that comes with Oat++. And, that find code doesn't set up the mbedtls targets expected by Oat++, just some variables (which I used instead). FYI: there are also log lines showing that pthreads4w is getting pulled in on the Azure build servers and that doesn't get pulled in on our servers either but that may be part of the FindMbedtls.cmake hijacking going on.

[BillyONeal]

there is a version of FindMbedtls.cmake somewhere on the Azure build servers

https://github.com/microsoft/vcpkg/blob/master/ports/mbedtls/vcpkg-cmake-wrapper.cmake is that override.

[mheyman]

there is a version of FindMbedtls.cmake somewhere on the Azure build servers

https://github.com/microsoft/vcpkg/blob/master/ports/mbedtls/vcpkg-cmake-wrapper.cmake is that override.

:-) Got it to work using that one or the one that comes with Oat++ for the rest of us

[KaungZawHtet]

1.2.0 is coming

[BillyONeal]

@NancyLi1013 is on vacation and I think she was waiting for a clean CI run anyway; it's passing now so I merged it.

Thanks for your contribution!

[NancyLi1013]

Thanks for your help and follow up @BillyONeal .

[KaungZawHtet]

it is still 1.0.0 when I do vcpkg search oatpp

[BillyONeal]

it is still 1.0.0 when I do vcpkg search oatpp

Did you do a git pull to update your vcpkg repo?

[KaungZawHtet]

opps! I notice what I missed. Thx