[vcpkg] Ignore dependencies not found errors when downloading mode #12323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:vcpkg-bug
|
@ras0219 @ras0219-msft @BillyONeal Do you have any suggestions? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219-msft
approved these changes
Jul 8, 2020
|
LGTM, thanks! |
PhoebeHui
changed the title
fabienfl-orc
pushed a commit
to DFIR-ORC/vcpkg
that referenced
this pull request
Jul 28, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcpkg/toolsrc/src/vcpkg/build.cpp
Line 957 in 811cb0c
Here, when the current port dependency is detected as unsuccessful, it will return failure, but it is not judged whether it is in download mode.
Fixes #10950.