Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg formatting] Turn off DeriveLineEnding #12368

Merged
merged 5 commits into from
Jul 14, 2020

Conversation

strega-nil
Copy link
Contributor

This PR removes CRLFs from existing C++ files, and standardizes upon the line ending \n.

This is not necessarily a thing we wish to do, so I'm labelling it requires:discussion.

@cenit
Copy link
Contributor

cenit commented Jul 12, 2020

Adding to the discussion, what about doing the same thing (and enforcing the rule with .gitattributes) also for port files, control files and patches?
Also file permissions (some port files have executable bit on...)

@ras0219-msft
Copy link
Contributor

We do like standardization, but we also don't want to waste people's time; an important factor that significantly reduces costs of imposing LF on code is that clang-format will automatically correct the issue without users even noticing (which we already require contributors to run anyway).

I think that before we move to enforce such conventions on port files, we should seek to have tooling that will automatically fix i t.

@cenit
Copy link
Contributor

cenit commented Jul 13, 2020

I think that before we move to enforce such conventions on port files, we should seek to have tooling that will automatically fix it.

isn't it possible to do it using git & enforcing gitattributes file? (that would have been true also for cpp files)

Since we're reformatting anyways
@strega-nil strega-nil merged commit d2620cf into microsoft:master Jul 14, 2020
@strega-nil strega-nil deleted the no-crlf branch July 14, 2020 15:56
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
* [vcpkg formatting] Turn off DeriveLineEnding

* format

* Add newlines to the end of files

Since we're reformatting anyways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants