Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-ci] Always publish file lists #12384

Merged

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jul 12, 2020

In PR builds, it is still sometimes useful to observe the list of files that will be produced from the new packages in the PR.

In CI builds, even if some packages fail to build or violate the baseline, it is useful to observe the incomplete list of files.

@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. labels Jul 13, 2020
headers.close()
output.close()
try:
headers = open("scripts/list_files/VCPKGHeadersDatabase.txt", mode='w')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preexisting: writing to the source tree == :(

@ras0219-msft ras0219-msft merged commit bc07f4b into microsoft:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants