Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opencolorio-tools] Separate feature application to avoid circular dependency #12420

Merged
merged 13 commits into from
Aug 10, 2020
Merged

[opencolorio-tools] Separate feature application to avoid circular dependency #12420

merged 13 commits into from
Aug 10, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 14, 2020 •
edited
Loading

The features of openimageio(opencolorio) and opencolorio(application) are dependent on each other.
According to the discussion, reorganize the build list, and separate opencolorio's feature applications into separate ports.

Build list should be :

  1. install opencolorio
  2. install openimageio[opencolorio]
  3. install opencolorio-tools

Fix build errror when building applications.

Fixes #9851.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support category:new-port The issue is requesting a new library to be added; consider making a PR! info:internal This PR or Issue was filed by the vcpkg team. labels Jul 14, 2020
@JackBoosY JackBoosY marked this pull request as ready for review July 15, 2020 05:42
@JackBoosY JackBoosY requested a review from PhoebeHui July 15, 2020 05:42
ras0219
ras0219 reviewed Jul 16, 2020
View reviewed changes
ports/opencolorio/portfile.cmake Outdated Show resolved Hide resolved
ports/opencolorio-tools/portfile.cmake Outdated Show resolved Hide resolved
ports/opencolorio-tools/0004-yaml-dependency-search.patch Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

opencolorio's feature 'applications' --> new port opencolorio-tools

Currently dependency list:
openimageio[opencolorio] --> Build-Depends: opencolorio
opencolorio --> Build-Depends: glew[core], freeglut[core], lcms[core], yaml-cpp[core], tinyxml[core]
opencolorio-tools --> Build-Depends: openimageio[opencolorio]

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2020
@strega-nil strega-nil merged commit fa1823d into microsoft:master Aug 10, 2020
@JackBoosY JackBoosY deleted the dev/jack/9851 branch August 11, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opencolorio and openimageio - cycle detected within graph at opencolorio:x64-windows
4 participants
@JackBoosY @PhoebeHui @ras0219 @strega-nil