Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg_configure_make: typo fix '_vcpkg_append_to_configure_environment' #12432

Merged
merged 1 commit into from
Jul 15, 2020
Merged

vcpkg_configure_make: typo fix '_vcpkg_append_to_configure_environment' #12432

merged 1 commit into from
Jul 15, 2020

Conversation

kevinlul
Copy link
Contributor

Fixes a small typo I came across in vcpkg_configure_make.

  • Which triplets are supported/not supported? Have you updated the CI baseline? Should not have observable external effects.

  • Does your PR follow the maintainer guide? Yes.

@JackBoosY JackBoosY self-assigned this Jul 15, 2020
@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines labels Jul 15, 2020
@Neumann-A
Copy link
Contributor

Nooo, more merge conflicts incoming ;)
That fix was originally a part of #11523 but I had to integrated it into #12183
I probably have to solve the conflicts anyway so nevermind ;)

@ras0219-msft ras0219-msft merged commit 85a5acf into microsoft:master Jul 15, 2020
@ras0219-msft
Copy link
Contributor

LGTM, sorry about the conflicts @Neumann-A :)

@kevinlul kevinlul deleted the vcpkg-configure-make-internal branch July 16, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinlul @Neumann-A @ras0219-msft @JackBoosY