Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] json format for search #12509

Merged
merged 4 commits into from
Sep 5, 2020
Merged

[vcpkg] json format for search #12509

merged 4 commits into from
Sep 5, 2020

Conversation

dan-shaw
Copy link
Contributor

No description provided.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Jul 21, 2020
toolsrc/src/vcpkg/commands.search.cpp Outdated Show resolved Hide resolved
@@ -16,7 +16,27 @@ using vcpkg::PortFileProvider::PathsPortFileProvider;
namespace vcpkg::Commands::Search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should ensure that we do not emit the survey message when passing x-json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think vcpkg runs the survey message when using the search command.

@BillyONeal BillyONeal merged commit bd8af07 into microsoft:master Sep 5, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants