-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg.cmake] check for vcpkg.json only in ${CMAKE_SOURCE_DIR}
#12523
Conversation
The question here is if you would like to support:
which loads all vcpkg.json recursively. Instead of only the one from the toplevel project. |
What is wrong with |
@Neumann-A solution != project. The former would have to be done via interdependencies, and is made no different by this change. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for your contribution :) |
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
So @Neumann-A has suggested this, and I think it's reasonable to do this. This means that we don't check outside of the directory containing the CMakeLists.txt.
I also have not changed the MSBuild, since I expect that many people will put their
vcpkg.json
into the solution directory, and there's not a standard variable for the solution directory. I'm not sure if this is the right thing to do; if anyone has opinions, please post them here.Also, cc @Neumann-A of course.