[vcpkg] Fix build on Windows 8.1 SDK #12586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:vcpkg-bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Jul 29, 2020
| const DWORD flags = SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE; | ||
| const DWORD flags = | ||
| #if defined(SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE) | ||
| SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE; |
There was a problem hiding this comment.
It might make sense to just say "2" or copy pasta the implementation from the Microsoft/STL repo.
There was a problem hiding this comment.
Given that we never actually get here, I'm going to worry about that when we rewrite the Files implementation :P
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12400 added
SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE, which was added in an SDK that is newer than the oldest we support. Therefore, check for the existence of that flag before we use it.cc @BillyONeal