Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[numcpp] Add new port #12682

Merged
merged 9 commits into from
Aug 20, 2020
Merged

[numcpp] Add new port #12682

merged 9 commits into from
Aug 20, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Aug 1, 2020

Describe the pull request

@NancyLi1013
Copy link
Contributor

Hi @myd7349
Thanks for this PR.

The failure on x64-linux is like his:

-- Installing: /mnt/vcpkg-ci/packages/numcpp_x64-linux/share/numcpp/copyright
-- Performing post-build validation
There should be no empty directories in /mnt/vcpkg-ci/packages/numcpp_x64-linux
The following empty directories were found:

    /mnt/vcpkg-ci/packages/numcpp_x64-linux/share/NumCpp

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:

    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")


Found 1 error(s). Please correct the portfile:
    /agent/_work/1/s/ports/numcpp/portfile.cmake
-- Performing post-build validation done
Error: Building package numcpp:x64-linux failed with: POST_BUILD_CHECKS_FAILED

Could you please fix it?

@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Aug 3, 2020
@myd7349
Copy link
Contributor Author

myd7349 commented Aug 6, 2020

Hi @myd7349
Thanks for this PR.

The failure on x64-linux is like his:

-- Installing: /mnt/vcpkg-ci/packages/numcpp_x64-linux/share/numcpp/copyright
-- Performing post-build validation
There should be no empty directories in /mnt/vcpkg-ci/packages/numcpp_x64-linux
The following empty directories were found:

    /mnt/vcpkg-ci/packages/numcpp_x64-linux/share/NumCpp

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:

    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")


Found 1 error(s). Please correct the portfile:
    /agent/_work/1/s/ports/numcpp/portfile.cmake
-- Performing post-build validation done
Error: Building package numcpp:x64-linux failed with: POST_BUILD_CHECKS_FAILED

Could you please fix it?

Thanks. I will look into it this weekend.

@myd7349 myd7349 marked this pull request as ready for review August 19, 2020 01:43
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 20, 2020
@BillyONeal BillyONeal merged commit a51f392 into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@myd7349 myd7349 deleted the numcpp-init branch August 20, 2020 10:14
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants