Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add png++ port (as pngpp) #12705

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Conversation

MCJack123
Copy link
Contributor

This PR adds png++, a C++ wrapper for libpng. This is a header-only package. It depends on libpng.

The package is named "pngpp" instead of "png++", since '+' characters seem to break something relating to the control file. (Maybe this is fixed with vcpkg.json manifests?)

This package supports all triplets, as no compilation is necessary. I have not updated the CI baseline.

This PR conforms to the maintainer guidelines.

@ghost
Copy link

ghost commented Aug 3, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 3, 2020
ports/pngpp/portfile.cmake Outdated Show resolved Hide resolved
ports/pngpp/portfile.cmake Show resolved Hide resolved
MCJack123 and others added 2 commits August 3, 2020 07:04
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@JackBoosY
Copy link
Contributor

JackBoosY commented Aug 4, 2020

The pbc:x64-osx regression is not related to this PR. Please wait for our to fix this (#12732).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2020
@strega-nil strega-nil merged commit 96adaeb into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* Create vcpkg.json

* Create portfile.cmake

* Fixed CI

* Update ports/pngpp/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

* Update ports/pngpp/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants