[vcpkg] Fix arm64-osx triplet not building for arm64 #12716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
changed the title
PhoebeHui
added
the
category:vcpkg-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
arm64-osxtriplet doesn't actually outputarm64binaries for macOS. If you runlipo -archs mylib.a, it will outputx86_64, which clearly isn't correct. This PR addsVCPKG_OSX_ARCHITECTURESto the triplet so that it correctly builds forarm64(as reported by thelipotool). Note: You may need the Xcode 12 beta for this to actually build for arm64; I'm not sure.This PR is a smaller change pulled from #12657 per discussion there.
No issues closed.
This fixes the community
arm64-osxtriplet. Nothing changed for CI.