Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Fix prettify output not working in some cases #12717

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

Deadpikle
Copy link
Contributor

If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for #12657, and this change was done by @strega-nil (thanks!). Relevant conversation in Discord here.

  • What does your PR fix?

No issues closed.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No changes made to triplets/CI.

If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for microsoft#12657 and was completed by @strega-nil (thanks!).
@LilyWangL LilyWangL changed the title Fix prettify output not working in some cases [vcpkg] Fix prettify output not working in some cases Aug 4, 2020
@LilyWangL LilyWangL added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 4, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2020
@strega-nil strega-nil merged commit 2ade390 into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for microsoft#12657 and was completed by @strega-nil (thanks!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants