Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue "print out missing path in read_lines" #12745. #12746

Merged
merged 1 commit into from Sep 11, 2020

Conversation

martin-s
Copy link
Contributor

@martin-s martin-s commented Aug 4, 2020

Describe the pull request

@ras0219-msft ras0219-msft merged commit e8790f0 into microsoft:master Sep 11, 2020
@ras0219-msft
Copy link
Contributor

This seems good to me, thanks for the improvement!

@BillyONeal
Copy link
Member

C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(79,1): error C2665: 'vcpkg::Strings::details::append_internal': none of the 4 overloads could convert all the argument types (compiling source file ..\src\v
cpkg\base\files.cpp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(54,17): message : could be 'void vcpkg::Strings::details::append_internal(std::string &,vcpkg::StringView)' (compiling source file ..\src\vcpkg\base\files.c
pp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(53,17): message : or       'void vcpkg::Strings::details::append_internal(std::string &,const std::string &)' (compiling source file ..\src\vcpkg\base\files 
.cpp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(52,17): message : or       'void vcpkg::Strings::details::append_internal(std::string &,const char *)' (compiling source file ..\src\vcpkg\base\files.cpp) [
C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(46,17): message : or       'void vcpkg::Strings::details::append_internal(std::string &,char)' (compiling source file ..\src\vcpkg\base\files.cpp) [C:\Dev\v
cpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(79,1): message : while trying to match the argument list '(std::string, const Arg)' [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
          with
          [
              Arg=std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>>
          ] (compiling source file ..\src\vcpkg\base\files.cpp)
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(84): message : see reference to function template instantiation 'std::string &vcpkg::Strings::append<Arg>(std::string &,const Arg &)' being compiled [C:\Dev
\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
          with
          [
              Arg=std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>>
          ] (compiling source file ..\src\vcpkg\base\files.cpp)
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(84): message : see reference to function template instantiation 'std::string &vcpkg::Strings::append<std::basic_string<char8_t,std::char_traits<char8_t>,std
::allocator<char8_t>>,char>(std::string &,const Arg &,const char &)' being compiled [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
          with
          [
              Arg=std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>>
          ] (compiling source file ..\src\vcpkg\base\files.cpp)
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(84): message : see reference to function template instantiation 'std::string &vcpkg::Strings::append<char[15],std::basic_string<char8_t,std::char_traits<cha
r8_t>,std::allocator<char8_t>>,char>(std::string &,const Arg (&),const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being compiled [C:\Dev\vcpkg\toolsrc\wind
ows-bootstrap\vcpkg.vcxproj]
          with
          [
              Arg=char [15]
          ] (compiling source file ..\src\vcpkg\base\files.cpp)
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(91): message : see reference to function template instantiation 'std::string &vcpkg::Strings::append<char[9],char[15],std::basic_string<char8_t,std::char_tr
aits<char8_t>,std::allocator<char8_t>>,char>(std::string &,const Arg (&),const char (&)[15],const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being compiled
 [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
          with
          [
              Arg=char [9]
          ] (compiling source file ..\src\vcpkg\base\files.cpp)
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\strings.h(99): message : see reference to function template instantiation 'std::string vcpkg::Strings::concat<char[9],char[15],std::basic_string<char8_t,std::char_tra
its<char8_t>,std::allocator<char8_t>>,char>(const char (&)[9],const char (&)[15],const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being compiled (compiling 
 source file ..\src\vcpkg\base\files.cpp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\system.print.h(41): message : see reference to function template instantiation 'std::string vcpkg::Strings::concat_or_view<char[9],char[15],std::basic_string<char8_t,
std::char_traits<char8_t>,std::allocator<char8_t>>,char,void>(const char (&)[9],const char (&)[15],const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being c
ompiled (compiling source file ..\src\vcpkg\base\files.cpp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\include\vcpkg\base\system.debug.h(20): message : see reference to function template instantiation 'void vcpkg::System::print2<char[9],char[15],std::basic_string<char8_t,std::char_traits
<char8_t>,std::allocator<char8_t>>,char>(const char (&)[9],const char (&)[15],const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being compiled (compiling so
urce file ..\src\vcpkg\base\files.cpp) [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcxproj]
C:\Dev\vcpkg\toolsrc\src\vcpkg\base\files.cpp(485): message : see reference to function template instantiation 'void vcpkg::Debug::print<char[15],std::basic_string<char8_t,std::char_traits<char8_t>,std::all
ocator<char8_t>>,char>(const char (&)[15],const std::basic_string<char8_t,std::char_traits<char8_t>,std::allocator<char8_t>> &,const char &)' being compiled [C:\Dev\vcpkg\toolsrc\windows-bootstrap\vcpkg.vcx 
proj]

this change fails to build for me.

@BillyONeal
Copy link
Member

#13489 Fixed here

@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Sep 14, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print out missing path in read_lines
4 participants