Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libtorrent] Update to 1.2.8 #12768

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[libtorrent] Update to 1.2.8 #12768

merged 2 commits into from
Aug 7, 2020

Conversation

FranciscoPombal
Copy link
Contributor

Here we go again...

No-change version bump.

Previously: #11709

NancyLi1013
NancyLi1013 reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have added Supports: !uwp in CONTROL file, there is no need to set the triplets as fail in ci.baseline.txt.

Could you please remove the following codes from ci.baseline.txt?

libtorrent:arm-uwp=fail
libtorrent:x64-uwp=fail

@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Aug 6, 2020
@NancyLi1013
Copy link
Contributor

Hi @FranciscoPombal
Thanks for this PR.

Have you tested these features? Do they work fine?

@FranciscoPombal
Copy link
Contributor Author

@NancyLi1013

Could you please remove the following codes from ci.baseline.txt?

Done.

Have you tested these features? Do they work fine?

Yes, looks good on my end.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 7, 2020
@strega-nil strega-nil merged commit 600743e into microsoft:master Aug 7, 2020
@FranciscoPombal FranciscoPombal deleted the update-libtorrent branch August 7, 2020 18:42
@FranciscoPombal FranciscoPombal mentioned this pull request Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FranciscoPombal @NancyLi1013 @strega-nil