Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[directxsdk] Add new Port #12778

Merged
merged 3 commits into from
Aug 10, 2020
Merged

[directxsdk] Add new Port #12778

merged 3 commits into from
Aug 10, 2020

Conversation

adrido
Copy link
Contributor

@adrido adrido commented Aug 6, 2020

This allows the DirectX SDK Jun10 to be "installed" with vcpkg.

scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@adrido adrido marked this pull request as ready for review August 6, 2020 09:04
adrido and others added 3 commits August 6, 2020 17:07
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 7, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2020
@strega-nil
Copy link
Contributor

strega-nil commented Aug 7, 2020

@adrido Could we rename this port directx-sdk? I think it reads better.

Otherwise, this looks fantastic. @ras0219, any thoughts?

@adrido
Copy link
Contributor Author

adrido commented Aug 8, 2020

I have chosen directxsdk to follow the naming scheme of the other directx ports:

PS E:\vcpkg> .\vcpkg.exe search directx
directxmesh          jul2020          DirectXMesh geometry processing library
directxsdk           jun10            DirectX SDK
directxtex           jul2020          DirectXTex texture processing library
directxtk            jul2020          A collection of helper classes for writing DirectX 11.x code in C++.
directxtk12          jul2020          A collection of helper classes for writing DirectX 12 code in C++.
dx                   1.0.1-1          A modern C++ library for DirectX programming
...

But yes, directx-sdk is better readable.

@strega-nil
Copy link
Contributor

hmm, I think you're right then. We may change it later once alias ports are a thing.

@strega-nil strega-nil merged commit ffd6ae4 into microsoft:master Aug 10, 2020
@fromasmtodisasm
Copy link

Hello, how are header files supposed to be used? Prefixed with directxsdk/ ?

like this?
#include <directxsdk/d3dx11.h>

if yes, then some old code will have to be rewritten, is there a smart way to specify the directxsdk folder as the search path?

@computerquip
Copy link

computerquip commented Jun 4, 2024

For those curious on how to use this properly, you can use find_path and find_library.

find_path(D3D9_INCLUDE_DIR d3dx9.h PATH_SUFFIXES directxsdk REQUIRED)
find_library(D3D9_LIBRARY d3d9 REQUIRED)

This sets <package>/include/directxsdk to D3D9_INCLUDE_DIR (i.e. you do not need to prefix your include with directxsdk) and d3d9.lib to D3D9_LIBRARY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Directx SDK to vcpkg
6 participants