Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmocka] Update to 2020-08-01 #12828

Merged
merged 4 commits into from
Aug 20, 2020
Merged

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Aug 9, 2020

Describe the pull request

  • What does your PR fix?
    N/A.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    N/A. No.

  • Does your PR follow the maintainer guide?
    No.

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 10, 2020
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove usage and vcpkg-cmake-wrapper? Could you please make it clarify for this?

@NancyLi1013
Copy link
Contributor

Hi @myd7349

Is this PR ready for review?

@myd7349
Copy link
Contributor Author

myd7349 commented Aug 19, 2020

Why do you remove usage and vcpkg-cmake-wrapper? Could you please make it clarify for this?

Hi! @NancyLi1013 Sorry for the long delay. cmocka's CMakeLists.txt has evolved a lot since the first commit of this port. And now it provides a modern CMake target:

find_package(cmocka CONFIG REQUIRED)
target_link_libraries(main PRIVATE cmocka::cmocka)

So the usage we had here is out of fashion.
For the same reason, the vcpkg-cmake-wrapper.cmake is unnecessary any more.

Hi @myd7349

Is this PR ready for review?

Yes. Please.

@myd7349 myd7349 marked this pull request as ready for review August 19, 2020 01:22
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 20, 2020
@BillyONeal BillyONeal merged commit fb8b20f into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@myd7349 myd7349 deleted the cmocka-2020-01-19 branch August 20, 2020 10:14
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants