Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] Interrupt the build process when files conflict #12867

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

JackBoosY
Copy link
Contributor

if(EXISTS "${CURRENT_INSTALLED_DIR}/include/openssl/ssl.h")
message(WARNING "Can't build openssl if libressl is installed. Please remove libressl, and try install openssl again if you need it. Build will continue but there might be problems since libressl is only a subset of openssl")
set(VCPKG_POLICY_EMPTY_PACKAGE enabled)
return()
endif()

This will make other ports that rely on it unable to find the files generated by openssl when they are building, thus hiding this issue.

Fixes #12443.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 12, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 18, 2020
@BillyONeal BillyONeal merged commit 547af51 into microsoft:master Aug 18, 2020
@BillyONeal
Copy link
Member

Thanks!

@JackBoosY JackBoosY deleted the dev/jack/12443 branch August 19, 2020 02:05
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libpq:x64-windows build failure
3 participants