-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add option cmake-args #12877
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This should probably imply/require --editable. |
@ras0219 This is not passed to the |
Sure, but the point is that these options can change the behavior of the package build -- that means they shouldn't be used as a basis for a cached binary tree. |
Then there needs to be a whitelist for cmake-args which don't imply --editable. (Mainly those vars mentioned in the very first comment.) |
We had a discussion about this at today's meeting, and our opinion is that:
Once those are in, we're up to merge. |
# Conflicts: # toolsrc/src/vcpkg/build.cpp
@strega-nil Done |
Thanks @Neumann-A |
* [vcpkg] Add option cmake-args to pass additional args to the script execution * apply clang format to install.cpp * rename command to x-cmake-args * imply editable if x-cmake-args are not empty. * don't use bitwise or * add a definition for CMAKE_SCRIPT_ARG Co-authored-by: wangli28 <wangli28@beyondsoft.com>
to pass additional args to the cmake script execution within vcpkg
things users/maintainers might want to pass:
--trace/--trace-expand
CMAKE_MESSAGE_LOG_LEVEL
CMAKE_MESSAGE_INDENT
CMAKE_MESSAGE_CONTEXT_SHOW/ --log-context (If vcpkg would use CMAKE_MESSAGE_CONTEXT)
PORT_DEBUG=ON